Skip to content

[DEV][LAZY CONSENSUS] Enable github policy to only require approval first time #18831

@tqchen

Description

@tqchen

Hi community:

We start to use github action for lint CI. Overall we have been very mindfully setting up the actions so that the workflow finishes fast and skip un-necessary ones when changes are detected to not have code changes.

During the process, we do find that when we get PRs, the approval then check process can cause delays for feedbacks for contributors. Sometimes the first gating tests like lint would greatly benefit from contributor PR directly triggers the CI. We have already done that for tvm-ffi so i assume it would be low risk requirment.

So this is a thread to seek consensus on changing the github action behavior to "only require approval first time". Please share your thoughts. Given this seems to be less controvesrial, we are going to open it as a lazy consensus thread, which means everyone is welcome chime in, and if nobody objects in 72 hours, we will proceed with a request for infra to update the setting.

This thread is mirrored to dev@

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions