[APIView] Allow comments on removed lines and show unresolved orphan comments in code view. #14216
Draft
tjprescott wants to merge 5 commits intomainfrom
Draft
[APIView] Allow comments on removed lines and show unresolved orphan comments in code view. #14216tjprescott wants to merge 5 commits intomainfrom
tjprescott wants to merge 5 commits intomainfrom
Conversation
tjprescott
force-pushed
the
apiview/ShowCommentsOnDeleted
branch
from
3855e19 to
3c8b558
Compare
tjprescott
force-pushed
the
apiview/ShowCommentsOnDeleted
branch
from
3c8b558 to
05b25ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the commenting and display of comment threads on removed lines in diff view.
It also displays a marker, similar to the "Resolve comment" marker, that shows unresolved threads that are "orphaned" (i.e. elementId is not including in current revision) so they can be expanded, reviewed and resolved.
TODO