Removing Wrong Spark Spans for Inactive Databricks Clusters#10651
Draft
larakulkarni1 wants to merge 8 commits intomasterfrom
Draft
Removing Wrong Spark Spans for Inactive Databricks Clusters#10651larakulkarni1 wants to merge 8 commits intomasterfrom
larakulkarni1 wants to merge 8 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~7646838a4b, baseline=1.60.0-SNAPSHOT~be0482d740
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1068174
Total [baseline] (10.888 s) : 0, 10887675
Agent [candidate] (1.075 s) : 0, 1074596
Total [candidate] (10.998 s) : 0, 10998119
section appsec
Agent [baseline] (1.248 s) : 0, 1247605
Total [baseline] (11.084 s) : 0, 11083689
Agent [candidate] (1.249 s) : 0, 1248799
Total [candidate] (11.093 s) : 0, 11092716
section iast
Agent [baseline] (1.239 s) : 0, 1239077
Total [baseline] (11.256 s) : 0, 11256308
Agent [candidate] (1.24 s) : 0, 1239837
Total [candidate] (11.241 s) : 0, 11241210
section profiling
Agent [baseline] (1.204 s) : 0, 1203671
Total [baseline] (11.031 s) : 0, 11030667
Agent [candidate] (1.193 s) : 0, 1193412
Total [candidate] (10.906 s) : 0, 10906074
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~7646838a4b, baseline=1.60.0-SNAPSHOT~be0482d740
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (629.396 ms) : 0, 629396
BytebuddyAgent [candidate] (633.164 ms) : 0, 633164
AgentMeter [baseline] (29.173 ms) : 0, 29173
AgentMeter [candidate] (29.355 ms) : 0, 29355
GlobalTracer [baseline] (258.169 ms) : 0, 258169
GlobalTracer [candidate] (259.519 ms) : 0, 259519
AppSec [baseline] (33.154 ms) : 0, 33154
AppSec [candidate] (33.08 ms) : 0, 33080
Debugger [baseline] (65.025 ms) : 0, 65025
Debugger [candidate] (66.068 ms) : 0, 66068
Remote Config [baseline] (624.143 µs) : 0, 624
Remote Config [candidate] (617.98 µs) : 0, 618
Telemetry [baseline] (10.689 ms) : 0, 10689
Telemetry [candidate] (9.189 ms) : 0, 9189
Flare Poller [baseline] (4.544 ms) : 0, 4544
Flare Poller [candidate] (6.124 ms) : 0, 6124
section appsec
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (662.348 ms) : 0, 662348
BytebuddyAgent [candidate] (663.54 ms) : 0, 663540
AgentMeter [baseline] (11.988 ms) : 0, 11988
AgentMeter [candidate] (11.991 ms) : 0, 11991
GlobalTracer [baseline] (259.786 ms) : 0, 259786
GlobalTracer [candidate] (259.803 ms) : 0, 259803
IAST [baseline] (25.796 ms) : 0, 25796
IAST [candidate] (25.701 ms) : 0, 25701
AppSec [baseline] (168.888 ms) : 0, 168888
AppSec [candidate] (168.817 ms) : 0, 168817
Debugger [baseline] (67.397 ms) : 0, 67397
Debugger [candidate] (67.387 ms) : 0, 67387
Remote Config [baseline] (670.845 µs) : 0, 671
Remote Config [candidate] (661.931 µs) : 0, 662
Telemetry [baseline] (9.511 ms) : 0, 9511
Telemetry [candidate] (9.498 ms) : 0, 9498
Flare Poller [baseline] (3.756 ms) : 0, 3756
Flare Poller [candidate] (3.815 ms) : 0, 3815
section iast
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (801.977 ms) : 0, 801977
BytebuddyAgent [candidate] (801.552 ms) : 0, 801552
AgentMeter [baseline] (11.541 ms) : 0, 11541
AgentMeter [candidate] (11.431 ms) : 0, 11431
GlobalTracer [baseline] (248.156 ms) : 0, 248156
GlobalTracer [candidate] (248.588 ms) : 0, 248588
IAST [baseline] (27.118 ms) : 0, 27118
IAST [candidate] (27.155 ms) : 0, 27155
AppSec [baseline] (34.984 ms) : 0, 34984
AppSec [candidate] (34.436 ms) : 0, 34436
Debugger [baseline] (65.383 ms) : 0, 65383
Debugger [candidate] (66.509 ms) : 0, 66509
Remote Config [baseline] (536.745 µs) : 0, 537
Remote Config [candidate] (550.108 µs) : 0, 550
Telemetry [baseline] (8.567 ms) : 0, 8567
Telemetry [candidate] (8.65 ms) : 0, 8650
Flare Poller [baseline] (3.397 ms) : 0, 3397
Flare Poller [candidate] (3.42 ms) : 0, 3420
section profiling
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (689.148 ms) : 0, 689148
BytebuddyAgent [candidate] (683.071 ms) : 0, 683071
AgentMeter [baseline] (8.71 ms) : 0, 8710
AgentMeter [candidate] (8.585 ms) : 0, 8585
GlobalTracer [baseline] (218.256 ms) : 0, 218256
GlobalTracer [candidate] (216.145 ms) : 0, 216145
AppSec [baseline] (33.267 ms) : 0, 33267
AppSec [candidate] (32.477 ms) : 0, 32477
Debugger [baseline] (67.948 ms) : 0, 67948
Debugger [candidate] (67.496 ms) : 0, 67496
Remote Config [baseline] (651.208 µs) : 0, 651
Remote Config [candidate] (645.386 µs) : 0, 645
Telemetry [baseline] (9.092 ms) : 0, 9092
Telemetry [candidate] (9.163 ms) : 0, 9163
Flare Poller [baseline] (3.83 ms) : 0, 3830
Flare Poller [candidate] (3.724 ms) : 0, 3724
ProfilingAgent [baseline] (100.554 ms) : 0, 100554
ProfilingAgent [candidate] (99.936 ms) : 0, 99936
Profiling [baseline] (101.139 ms) : 0, 101139
Profiling [candidate] (100.507 ms) : 0, 100507
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~7646838a4b, baseline=1.60.0-SNAPSHOT~be0482d740
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069398
Total [baseline] (8.769 s) : 0, 8768755
Agent [candidate] (1.068 s) : 0, 1068431
Total [candidate] (8.742 s) : 0, 8741970
section iast
Agent [baseline] (1.232 s) : 0, 1231523
Total [baseline] (9.385 s) : 0, 9385429
Agent [candidate] (1.231 s) : 0, 1231039
Total [candidate] (9.395 s) : 0, 9394944
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~7646838a4b, baseline=1.60.0-SNAPSHOT~be0482d740
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.224 ms) : 0, 1224
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (631.914 ms) : 0, 631914
BytebuddyAgent [candidate] (630.085 ms) : 0, 630085
AgentMeter [baseline] (29.419 ms) : 0, 29419
AgentMeter [candidate] (29.167 ms) : 0, 29167
GlobalTracer [baseline] (258.412 ms) : 0, 258412
GlobalTracer [candidate] (258.131 ms) : 0, 258131
AppSec [baseline] (33.06 ms) : 0, 33060
AppSec [candidate] (32.774 ms) : 0, 32774
Debugger [baseline] (62.327 ms) : 0, 62327
Debugger [candidate] (62.689 ms) : 0, 62689
Remote Config [baseline] (622.131 µs) : 0, 622
Remote Config [candidate] (615.768 µs) : 0, 616
Telemetry [baseline] (11.564 ms) : 0, 11564
Telemetry [candidate] (10.627 ms) : 0, 10627
Flare Poller [baseline] (4.486 ms) : 0, 4486
Flare Poller [candidate] (6.81 ms) : 0, 6810
section iast
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (796.131 ms) : 0, 796131
BytebuddyAgent [candidate] (795.605 ms) : 0, 795605
AgentMeter [baseline] (11.31 ms) : 0, 11310
AgentMeter [candidate] (11.311 ms) : 0, 11311
GlobalTracer [baseline] (247.542 ms) : 0, 247542
GlobalTracer [candidate] (247.442 ms) : 0, 247442
IAST [baseline] (27.239 ms) : 0, 27239
IAST [candidate] (26.88 ms) : 0, 26880
AppSec [baseline] (34.722 ms) : 0, 34722
AppSec [candidate] (34.037 ms) : 0, 34037
Debugger [baseline] (64.566 ms) : 0, 64566
Debugger [candidate] (65.665 ms) : 0, 65665
Remote Config [baseline] (549.449 µs) : 0, 549
Remote Config [candidate] (538.262 µs) : 0, 538
Telemetry [baseline] (8.647 ms) : 0, 8647
Telemetry [candidate] (8.699 ms) : 0, 8699
Flare Poller [baseline] (3.481 ms) : 0, 3481
Flare Poller [candidate] (3.512 ms) : 0, 3512
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~7646838a4b, baseline=1.60.0-SNAPSHOT~be0482d740
dateFormat X
axisFormat %s
section baseline
no_agent (1.185 ms) : 1173, 1196
. : milestone, 1185,
iast (2.98 ms) : 2944, 3016
. : milestone, 2980,
iast_FULL (5.724 ms) : 5667, 5781
. : milestone, 5724,
iast_GLOBAL (3.484 ms) : 3430, 3538
. : milestone, 3484,
profiling (2.172 ms) : 2150, 2193
. : milestone, 2172,
tracing (1.747 ms) : 1732, 1762
. : milestone, 1747,
section candidate
no_agent (1.26 ms) : 1246, 1274
. : milestone, 1260,
iast (3.009 ms) : 2971, 3048
. : milestone, 3009,
iast_FULL (5.997 ms) : 5936, 6058
. : milestone, 5997,
iast_GLOBAL (3.587 ms) : 3521, 3652
. : milestone, 3587,
profiling (2.055 ms) : 2037, 2074
. : milestone, 2055,
tracing (1.852 ms) : 1836, 1868
. : milestone, 1852,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~7646838a4b, baseline=1.60.0-SNAPSHOT~be0482d740
dateFormat X
axisFormat %s
section baseline
no_agent (18.061 ms) : 17873, 18249
. : milestone, 18061,
appsec (18.705 ms) : 18513, 18897
. : milestone, 18705,
code_origins (17.939 ms) : 17755, 18123
. : milestone, 17939,
iast (17.617 ms) : 17444, 17791
. : milestone, 17617,
profiling (19.698 ms) : 19496, 19899
. : milestone, 19698,
tracing (18.161 ms) : 17978, 18344
. : milestone, 18161,
section candidate
no_agent (18.047 ms) : 17862, 18233
. : milestone, 18047,
appsec (18.707 ms) : 18518, 18895
. : milestone, 18707,
code_origins (17.692 ms) : 17515, 17869
. : milestone, 17692,
iast (17.693 ms) : 17514, 17871
. : milestone, 17693,
profiling (18.913 ms) : 18724, 19102
. : milestone, 18913,
tracing (17.607 ms) : 17433, 17782
. : milestone, 17607,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~7646838a4b, baseline=1.60.0-SNAPSHOT~be0482d740
dateFormat X
axisFormat %s
section baseline
no_agent (14.948 s) : 14948000, 14948000
. : milestone, 14948000,
appsec (14.808 s) : 14808000, 14808000
. : milestone, 14808000,
iast (18.555 s) : 18555000, 18555000
. : milestone, 18555000,
iast_GLOBAL (17.885 s) : 17885000, 17885000
. : milestone, 17885000,
profiling (15.284 s) : 15284000, 15284000
. : milestone, 15284000,
tracing (14.726 s) : 14726000, 14726000
. : milestone, 14726000,
section candidate
no_agent (14.942 s) : 14942000, 14942000
. : milestone, 14942000,
appsec (14.959 s) : 14959000, 14959000
. : milestone, 14959000,
iast (18.078 s) : 18078000, 18078000
. : milestone, 18078000,
iast_GLOBAL (17.868 s) : 17868000, 17868000
. : milestone, 17868000,
profiling (15.439 s) : 15439000, 15439000
. : milestone, 15439000,
tracing (14.683 s) : 14683000, 14683000
. : milestone, 14683000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~7646838a4b, baseline=1.60.0-SNAPSHOT~be0482d740
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.819 ms) : 3597, 4042
. : milestone, 3819,
iast (2.247 ms) : 2179, 2315
. : milestone, 2247,
iast_GLOBAL (2.292 ms) : 2223, 2361
. : milestone, 2292,
profiling (2.112 ms) : 2055, 2168
. : milestone, 2112,
tracing (2.077 ms) : 2024, 2131
. : milestone, 2077,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.808 ms) : 3586, 4030
. : milestone, 3808,
iast (2.251 ms) : 2182, 2320
. : milestone, 2251,
iast_GLOBAL (2.31 ms) : 2241, 2380
. : milestone, 2310,
profiling (2.088 ms) : 2034, 2143
. : milestone, 2088,
tracing (2.062 ms) : 2008, 2115
. : milestone, 2062,
|
8bf15a0 to
fb1450e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.