Skip to content

Mute tracing for agent http calls#10690

Open
PerfectSlayer wants to merge 2 commits intomasterfrom
bbujon/http-mute
Open

Mute tracing for agent http calls#10690
PerfectSlayer wants to merge 2 commits intomasterfrom
bbujon/http-mute

Conversation

@PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Feb 26, 2026

What Does This Do

This PR generalizes muting the tracing for HTTP client calls.
Originally only applied to OkHttp3, it will now be applied to JDK HTTP Client too.

Additionally, it fixes the fact that current active spans are getting injected propagation headers when application access the request headers - independently of the injection mechanism.

Motivation

Start leveraging JDK HTTP client as HTTP client.

Additional Notes

Also does a bit of clean up of the java-net instrumentation (deprecated API, static imports).

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@PerfectSlayer PerfectSlayer added the type: enhancement Enhancements and improvements label Feb 26, 2026
@PerfectSlayer PerfectSlayer requested a review from a team as a code owner February 26, 2026 15:17
@PerfectSlayer PerfectSlayer added the inst: java Core Java language instrumentation label Feb 26, 2026
Copy link
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pr-commenter
Copy link

pr-commenter bot commented Feb 26, 2026

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/http-mute
git_commit_date 1772200579 1772223968
git_commit_sha c6896b7 987d87b
release_version 1.60.0-SNAPSHOT~c6896b7cf7 1.60.0-SNAPSHOT~987d87bfff
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1772225958 1772225958
ci_job_id 1464234158 1464234158
ci_pipeline_id 99536729 99536729
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-3npe2f5b 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-3npe2f5b 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics.

Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~987d87bfff, baseline=1.60.0-SNAPSHOT~c6896b7cf7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064723
Total [baseline] (10.898 s) : 0, 10897532
Agent [candidate] (1.064 s) : 0, 1063917
Total [candidate] (10.891 s) : 0, 10891448
section appsec
Agent [baseline] (1.236 s) : 0, 1236249
Total [baseline] (11.021 s) : 0, 11020854
Agent [candidate] (1.247 s) : 0, 1246945
Total [candidate] (11.053 s) : 0, 11053249
section iast
Agent [baseline] (1.23 s) : 0, 1230207
Total [baseline] (11.165 s) : 0, 11164889
Agent [candidate] (1.236 s) : 0, 1236301
Total [candidate] (11.191 s) : 0, 11191172
section profiling
Agent [baseline] (1.197 s) : 0, 1197095
Total [baseline] (10.991 s) : 0, 10990810
Agent [candidate] (1.194 s) : 0, 1194187
Total [candidate] (11.054 s) : 0, 11054488
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent appsec 1.236 s 171.527 ms (16.1%)
Agent iast 1.23 s 165.484 ms (15.5%)
Agent profiling 1.197 s 132.373 ms (12.4%)
Total tracing 10.898 s -
Total appsec 11.021 s 123.322 ms (1.1%)
Total iast 11.165 s 267.357 ms (2.5%)
Total profiling 10.991 s 93.278 ms (0.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.247 s 183.027 ms (17.2%)
Agent iast 1.236 s 172.383 ms (16.2%)
Agent profiling 1.194 s 130.269 ms (12.2%)
Total tracing 10.891 s -
Total appsec 11.053 s 161.802 ms (1.5%)
Total iast 11.191 s 299.724 ms (2.8%)
Total profiling 11.054 s 163.041 ms (1.5%)
gantt
    title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~987d87bfff, baseline=1.60.0-SNAPSHOT~c6896b7cf7

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (628.035 ms) : 0, 628035
BytebuddyAgent [candidate] (627.451 ms) : 0, 627451
AgentMeter [baseline] (29.234 ms) : 0, 29234
AgentMeter [candidate] (29.196 ms) : 0, 29196
GlobalTracer [baseline] (258.014 ms) : 0, 258014
GlobalTracer [candidate] (257.438 ms) : 0, 257438
AppSec [baseline] (33.135 ms) : 0, 33135
AppSec [candidate] (33.074 ms) : 0, 33074
Debugger [baseline] (63.734 ms) : 0, 63734
Debugger [candidate] (64.512 ms) : 0, 64512
Remote Config [baseline] (626.544 µs) : 0, 627
Remote Config [candidate] (612.47 µs) : 0, 612
Telemetry [baseline] (9.196 ms) : 0, 9196
Telemetry [candidate] (9.139 ms) : 0, 9139
Flare Poller [baseline] (5.415 ms) : 0, 5415
Flare Poller [candidate] (5.282 ms) : 0, 5282
section appsec
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (656.24 ms) : 0, 656240
BytebuddyAgent [candidate] (662.597 ms) : 0, 662597
AgentMeter [baseline] (11.947 ms) : 0, 11947
AgentMeter [candidate] (12.153 ms) : 0, 12153
GlobalTracer [baseline] (258.009 ms) : 0, 258009
GlobalTracer [candidate] (259.924 ms) : 0, 259924
IAST [baseline] (25.326 ms) : 0, 25326
IAST [candidate] (25.496 ms) : 0, 25496
AppSec [baseline] (167.431 ms) : 0, 167431
AppSec [candidate] (168.865 ms) : 0, 168865
Debugger [baseline] (66.394 ms) : 0, 66394
Debugger [candidate] (66.845 ms) : 0, 66845
Remote Config [baseline] (697.624 µs) : 0, 698
Remote Config [candidate] (679.055 µs) : 0, 679
Telemetry [baseline] (9.34 ms) : 0, 9340
Telemetry [candidate] (9.416 ms) : 0, 9416
Flare Poller [baseline] (3.679 ms) : 0, 3679
Flare Poller [candidate] (3.601 ms) : 0, 3601
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (793.945 ms) : 0, 793945
BytebuddyAgent [candidate] (800.204 ms) : 0, 800204
AgentMeter [baseline] (11.261 ms) : 0, 11261
AgentMeter [candidate] (11.321 ms) : 0, 11321
GlobalTracer [baseline] (247.175 ms) : 0, 247175
GlobalTracer [candidate] (247.428 ms) : 0, 247428
IAST [baseline] (26.96 ms) : 0, 26960
IAST [candidate] (26.996 ms) : 0, 26996
AppSec [baseline] (35.031 ms) : 0, 35031
AppSec [candidate] (31.458 ms) : 0, 31458
Debugger [baseline] (66.072 ms) : 0, 66072
Debugger [candidate] (68.939 ms) : 0, 68939
Remote Config [baseline] (544.725 µs) : 0, 545
Remote Config [candidate] (536.086 µs) : 0, 536
Telemetry [baseline] (8.565 ms) : 0, 8565
Telemetry [candidate] (8.661 ms) : 0, 8661
Flare Poller [baseline] (3.471 ms) : 0, 3471
Flare Poller [candidate] (3.509 ms) : 0, 3509
section profiling
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.166 ms) : 0, 1166
BytebuddyAgent [baseline] (687.23 ms) : 0, 687230
BytebuddyAgent [candidate] (682.338 ms) : 0, 682338
AgentMeter [baseline] (8.604 ms) : 0, 8604
AgentMeter [candidate] (8.55 ms) : 0, 8550
GlobalTracer [baseline] (216.791 ms) : 0, 216791
GlobalTracer [candidate] (217.655 ms) : 0, 217655
AppSec [baseline] (32.487 ms) : 0, 32487
AppSec [candidate] (33.223 ms) : 0, 33223
Debugger [baseline] (66.904 ms) : 0, 66904
Debugger [candidate] (67.593 ms) : 0, 67593
Remote Config [baseline] (619.842 µs) : 0, 620
Remote Config [candidate] (628.116 µs) : 0, 628
Telemetry [baseline] (8.911 ms) : 0, 8911
Telemetry [candidate] (8.95 ms) : 0, 8950
Flare Poller [baseline] (3.784 ms) : 0, 3784
Flare Poller [candidate] (3.845 ms) : 0, 3845
ProfilingAgent [baseline] (99.446 ms) : 0, 99446
ProfilingAgent [candidate] (99.362 ms) : 0, 99362
Profiling [baseline] (100.025 ms) : 0, 100025
Profiling [candidate] (99.943 ms) : 0, 99943
Loading
Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~987d87bfff, baseline=1.60.0-SNAPSHOT~c6896b7cf7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068828
Total [baseline] (8.77 s) : 0, 8770285
Agent [candidate] (1.065 s) : 0, 1065092
Total [candidate] (8.774 s) : 0, 8774379
section iast
Agent [baseline] (1.238 s) : 0, 1237736
Total [baseline] (9.356 s) : 0, 9356471
Agent [candidate] (1.236 s) : 0, 1235514
Total [candidate] (9.358 s) : 0, 9358384
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent iast 1.238 s 168.908 ms (15.8%)
Total tracing 8.77 s -
Total iast 9.356 s 586.185 ms (6.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.236 s 170.422 ms (16.0%)
Total tracing 8.774 s -
Total iast 9.358 s 584.005 ms (6.7%)
gantt
    title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~987d87bfff, baseline=1.60.0-SNAPSHOT~c6896b7cf7

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (631.544 ms) : 0, 631544
BytebuddyAgent [candidate] (627.864 ms) : 0, 627864
AgentMeter [baseline] (29.264 ms) : 0, 29264
AgentMeter [candidate] (29.256 ms) : 0, 29256
GlobalTracer [baseline] (258.392 ms) : 0, 258392
GlobalTracer [candidate] (258.516 ms) : 0, 258516
AppSec [baseline] (33.248 ms) : 0, 33248
AppSec [candidate] (33.045 ms) : 0, 33045
Debugger [baseline] (65.559 ms) : 0, 65559
Debugger [candidate] (62.3 ms) : 0, 62300
Remote Config [baseline] (609.001 µs) : 0, 609
Remote Config [candidate] (612.373 µs) : 0, 612
Telemetry [baseline] (9.084 ms) : 0, 9084
Telemetry [candidate] (10.705 ms) : 0, 10705
Flare Poller [baseline] (3.774 ms) : 0, 3774
Flare Poller [candidate] (5.354 ms) : 0, 5354
section iast
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (800.391 ms) : 0, 800391
BytebuddyAgent [candidate] (798.076 ms) : 0, 798076
AgentMeter [baseline] (11.502 ms) : 0, 11502
AgentMeter [candidate] (11.391 ms) : 0, 11391
GlobalTracer [baseline] (248.213 ms) : 0, 248213
GlobalTracer [candidate] (248.918 ms) : 0, 248918
IAST [baseline] (27.08 ms) : 0, 27080
IAST [candidate] (27.131 ms) : 0, 27131
AppSec [baseline] (32.669 ms) : 0, 32669
AppSec [candidate] (34.245 ms) : 0, 34245
Debugger [baseline] (68.062 ms) : 0, 68062
Debugger [candidate] (65.745 ms) : 0, 65745
Remote Config [baseline] (534.63 µs) : 0, 535
Remote Config [candidate] (547.725 µs) : 0, 548
Telemetry [baseline] (8.6 ms) : 0, 8600
Telemetry [candidate] (8.785 ms) : 0, 8785
Flare Poller [baseline] (3.464 ms) : 0, 3464
Flare Poller [candidate] (3.521 ms) : 0, 3521
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/http-mute
git_commit_date 1772200579 1772223968
git_commit_sha c6896b7 987d87b
release_version 1.60.0-SNAPSHOT~c6896b7cf7 1.60.0-SNAPSHOT~987d87bfff
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1772226445 1772226445
ci_job_id 1464234159 1464234159
ci_pipeline_id 99536729 99536729
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-zml3huqf 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-zml3huqf 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:profiling:high_load better
[-182.284µs; -56.404µs] or [-10.411%; -3.221%]
unstable
[-1086.701µs; -144.411µs] or [-20.468%; -2.720%]
unstable
[-61.334op/s; +455.459op/s] or [-2.995%; +22.239%]
1.632ms 4.694ms 2245.125op/s 1.751ms 5.309ms 2048.062op/s
scenario:load:petclinic:code_origins:high_load better
[-2.149ms; -1.168ms] or [-11.528%; -6.265%]
better
[-2.340ms; -1.097ms] or [-7.840%; -3.676%]
unstable
[-9.741op/s; +50.491op/s] or [-3.930%; +20.370%]
16.985ms 28.134ms 268.250op/s 18.644ms 29.853ms 247.875op/s
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~987d87bfff, baseline=1.60.0-SNAPSHOT~c6896b7cf7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.183 ms) : 1171, 1195
.   : milestone, 1183,
iast (3.241 ms) : 3197, 3284
.   : milestone, 3241,
iast_FULL (5.925 ms) : 5866, 5985
.   : milestone, 5925,
iast_GLOBAL (3.511 ms) : 3451, 3572
.   : milestone, 3511,
profiling (2.211 ms) : 2188, 2233
.   : milestone, 2211,
tracing (1.852 ms) : 1835, 1869
.   : milestone, 1852,
section candidate
no_agent (1.182 ms) : 1170, 1193
.   : milestone, 1182,
iast (3.179 ms) : 3139, 3218
.   : milestone, 3179,
iast_FULL (5.926 ms) : 5865, 5986
.   : milestone, 5926,
iast_GLOBAL (3.5 ms) : 3447, 3552
.   : milestone, 3500,
profiling (2.011 ms) : 1993, 2029
.   : milestone, 2011,
tracing (1.814 ms) : 1799, 1830
.   : milestone, 1814,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.183 ms [1.171 ms, 1.195 ms] -
iast 3.241 ms [3.197 ms, 3.284 ms] 2.057 ms (173.9%)
iast_FULL 5.925 ms [5.866 ms, 5.985 ms] 4.742 ms (400.8%)
iast_GLOBAL 3.511 ms [3.451 ms, 3.572 ms] 2.328 ms (196.7%)
profiling 2.211 ms [2.188 ms, 2.233 ms] 1.028 ms (86.8%)
tracing 1.852 ms [1.835 ms, 1.869 ms] 668.778 µs (56.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.182 ms [1.17 ms, 1.193 ms] -
iast 3.179 ms [3.139 ms, 3.218 ms] 1.997 ms (168.9%)
iast_FULL 5.926 ms [5.865 ms, 5.986 ms] 4.744 ms (401.4%)
iast_GLOBAL 3.5 ms [3.447 ms, 3.552 ms] 2.318 ms (196.1%)
profiling 2.011 ms [1.993 ms, 2.029 ms] 829.225 µs (70.2%)
tracing 1.814 ms [1.799 ms, 1.83 ms] 632.482 µs (53.5%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~987d87bfff, baseline=1.60.0-SNAPSHOT~c6896b7cf7
    dateFormat X
    axisFormat %s
section baseline
no_agent (17.07 ms) : 16901, 17240
.   : milestone, 17070,
appsec (18.553 ms) : 18365, 18740
.   : milestone, 18553,
code_origins (18.83 ms) : 18644, 19017
.   : milestone, 18830,
iast (17.443 ms) : 17271, 17615
.   : milestone, 17443,
profiling (18.603 ms) : 18419, 18786
.   : milestone, 18603,
tracing (17.65 ms) : 17473, 17828
.   : milestone, 17650,
section candidate
no_agent (17.87 ms) : 17686, 18054
.   : milestone, 17870,
appsec (18.864 ms) : 18673, 19054
.   : milestone, 18864,
code_origins (17.395 ms) : 17223, 17566
.   : milestone, 17395,
iast (17.76 ms) : 17583, 17936
.   : milestone, 17760,
profiling (18.497 ms) : 18311, 18682
.   : milestone, 18497,
tracing (17.697 ms) : 17519, 17874
.   : milestone, 17697,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 17.07 ms [16.901 ms, 17.24 ms] -
appsec 18.553 ms [18.365 ms, 18.74 ms] 1.482 ms (8.7%)
code_origins 18.83 ms [18.644 ms, 19.017 ms] 1.76 ms (10.3%)
iast 17.443 ms [17.271 ms, 17.615 ms] 372.451 µs (2.2%)
profiling 18.603 ms [18.419 ms, 18.786 ms] 1.532 ms (9.0%)
tracing 17.65 ms [17.473 ms, 17.828 ms] 580.07 µs (3.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 17.87 ms [17.686 ms, 18.054 ms] -
appsec 18.864 ms [18.673 ms, 19.054 ms] 993.595 µs (5.6%)
code_origins 17.395 ms [17.223 ms, 17.566 ms] -475.166 µs (-2.7%)
iast 17.76 ms [17.583 ms, 17.936 ms] -110.294 µs (-0.6%)
profiling 18.497 ms [18.311 ms, 18.682 ms] 626.923 µs (3.5%)
tracing 17.697 ms [17.519 ms, 17.874 ms] -173.035 µs (-1.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/http-mute
git_commit_date 1772200579 1772223968
git_commit_sha c6896b7 987d87b
release_version 1.60.0-SNAPSHOT~c6896b7cf7 1.60.0-SNAPSHOT~987d87bfff
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1772226249 1772226249
ci_job_id 1464234160 1464234160
ci_pipeline_id 99536729 99536729
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-1y90gql8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-1y90gql8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~987d87bfff, baseline=1.60.0-SNAPSHOT~c6896b7cf7
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.985 s) : 14985000, 14985000
.   : milestone, 14985000,
appsec (15.023 s) : 15023000, 15023000
.   : milestone, 15023000,
iast (17.71 s) : 17710000, 17710000
.   : milestone, 17710000,
iast_GLOBAL (17.699 s) : 17699000, 17699000
.   : milestone, 17699000,
profiling (14.892 s) : 14892000, 14892000
.   : milestone, 14892000,
tracing (14.855 s) : 14855000, 14855000
.   : milestone, 14855000,
section candidate
no_agent (14.995 s) : 14995000, 14995000
.   : milestone, 14995000,
appsec (14.835 s) : 14835000, 14835000
.   : milestone, 14835000,
iast (17.725 s) : 17725000, 17725000
.   : milestone, 17725000,
iast_GLOBAL (17.958 s) : 17958000, 17958000
.   : milestone, 17958000,
profiling (14.999 s) : 14999000, 14999000
.   : milestone, 14999000,
tracing (14.832 s) : 14832000, 14832000
.   : milestone, 14832000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.985 s [14.985 s, 14.985 s] -
appsec 15.023 s [15.023 s, 15.023 s] 38.0 ms (0.3%)
iast 17.71 s [17.71 s, 17.71 s] 2.725 s (18.2%)
iast_GLOBAL 17.699 s [17.699 s, 17.699 s] 2.714 s (18.1%)
profiling 14.892 s [14.892 s, 14.892 s] -93.0 ms (-0.6%)
tracing 14.855 s [14.855 s, 14.855 s] -130.0 ms (-0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.995 s [14.995 s, 14.995 s] -
appsec 14.835 s [14.835 s, 14.835 s] -160.0 ms (-1.1%)
iast 17.725 s [17.725 s, 17.725 s] 2.73 s (18.2%)
iast_GLOBAL 17.958 s [17.958 s, 17.958 s] 2.963 s (19.8%)
profiling 14.999 s [14.999 s, 14.999 s] 4.0 ms (0.0%)
tracing 14.832 s [14.832 s, 14.832 s] -163.0 ms (-1.1%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~987d87bfff, baseline=1.60.0-SNAPSHOT~c6896b7cf7
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (3.78 ms) : 3559, 4002
.   : milestone, 3780,
iast (2.235 ms) : 2166, 2304
.   : milestone, 2235,
iast_GLOBAL (2.286 ms) : 2217, 2356
.   : milestone, 2286,
profiling (2.065 ms) : 2010, 2119
.   : milestone, 2065,
tracing (2.044 ms) : 1991, 2097
.   : milestone, 2044,
section candidate
no_agent (1.467 ms) : 1455, 1479
.   : milestone, 1467,
appsec (3.73 ms) : 3511, 3950
.   : milestone, 3730,
iast (2.241 ms) : 2173, 2310
.   : milestone, 2241,
iast_GLOBAL (2.291 ms) : 2221, 2360
.   : milestone, 2291,
profiling (2.077 ms) : 2022, 2132
.   : milestone, 2077,
tracing (2.056 ms) : 2003, 2109
.   : milestone, 2056,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.48 ms] -
appsec 3.78 ms [3.559 ms, 4.002 ms] 2.311 ms (157.3%)
iast 2.235 ms [2.166 ms, 2.304 ms] 765.895 µs (52.1%)
iast_GLOBAL 2.286 ms [2.217 ms, 2.356 ms] 817.523 µs (55.7%)
profiling 2.065 ms [2.01 ms, 2.119 ms] 595.632 µs (40.6%)
tracing 2.044 ms [1.991 ms, 2.097 ms] 575.458 µs (39.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.479 ms] -
appsec 3.73 ms [3.511 ms, 3.95 ms] 2.263 ms (154.3%)
iast 2.241 ms [2.173 ms, 2.31 ms] 774.291 µs (52.8%)
iast_GLOBAL 2.291 ms [2.221 ms, 2.36 ms] 823.936 µs (56.2%)
profiling 2.077 ms [2.022 ms, 2.132 ms] 609.846 µs (41.6%)
tracing 2.056 ms [2.003 ms, 2.109 ms] 589.145 µs (40.2%)

…request.

This fixes the fact that current active span - so not always the http client span - is being injected context propagation headers when user interacts with the request headers.
@PerfectSlayer
Copy link
Contributor Author

@mcculls I updated the PR with a second commit to fix unexpected header injections on current span when interacting with headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: java Core Java language instrumentation type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants