[WIP] Revisit and unify profiling settings#10694
Draft
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~feb6c691d8, baseline=1.60.0-SNAPSHOT~969d21d507
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064188
Total [baseline] (10.927 s) : 0, 10927128
Agent [candidate] (1.067 s) : 0, 1066798
Total [candidate] (10.818 s) : 0, 10817814
section appsec
Agent [baseline] (1.236 s) : 0, 1236320
Total [baseline] (10.956 s) : 0, 10955590
Agent [candidate] (1.238 s) : 0, 1237655
Total [candidate] (10.97 s) : 0, 10969925
section iast
Agent [baseline] (1.249 s) : 0, 1248901
Total [baseline] (11.295 s) : 0, 11295353
Agent [candidate] (1.237 s) : 0, 1236662
Total [candidate] (11.237 s) : 0, 11237387
section profiling
Agent [baseline] (1.19 s) : 0, 1190348
Total [baseline] (11.013 s) : 0, 11012937
Agent [candidate] (1.192 s) : 0, 1192154
Total [candidate] (10.912 s) : 0, 10911916
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~feb6c691d8, baseline=1.60.0-SNAPSHOT~969d21d507
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (627.441 ms) : 0, 627441
BytebuddyAgent [candidate] (629.31 ms) : 0, 629310
AgentMeter [baseline] (29.041 ms) : 0, 29041
AgentMeter [candidate] (29.12 ms) : 0, 29120
GlobalTracer [baseline] (257.506 ms) : 0, 257506
GlobalTracer [candidate] (257.861 ms) : 0, 257861
AppSec [baseline] (32.733 ms) : 0, 32733
AppSec [candidate] (32.891 ms) : 0, 32891
Debugger [baseline] (65.902 ms) : 0, 65902
Debugger [candidate] (62.932 ms) : 0, 62932
Remote Config [baseline] (602.16 µs) : 0, 602
Remote Config [candidate] (616.813 µs) : 0, 617
Telemetry [baseline] (9.897 ms) : 0, 9897
Telemetry [candidate] (11.497 ms) : 0, 11497
Flare Poller [baseline] (3.76 ms) : 0, 3760
Flare Poller [candidate] (5.345 ms) : 0, 5345
section appsec
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (656.717 ms) : 0, 656717
BytebuddyAgent [candidate] (657.8 ms) : 0, 657800
AgentMeter [baseline] (11.911 ms) : 0, 11911
AgentMeter [candidate] (11.915 ms) : 0, 11915
GlobalTracer [baseline] (257.779 ms) : 0, 257779
GlobalTracer [candidate] (257.923 ms) : 0, 257923
IAST [baseline] (25.344 ms) : 0, 25344
IAST [candidate] (25.38 ms) : 0, 25380
AppSec [baseline] (167.668 ms) : 0, 167668
AppSec [candidate] (167.432 ms) : 0, 167432
Debugger [baseline] (66.336 ms) : 0, 66336
Debugger [candidate] (66.498 ms) : 0, 66498
Remote Config [baseline] (641.393 µs) : 0, 641
Remote Config [candidate] (678.236 µs) : 0, 678
Telemetry [baseline] (9.251 ms) : 0, 9251
Telemetry [candidate] (9.28 ms) : 0, 9280
Flare Poller [baseline] (3.547 ms) : 0, 3547
Flare Poller [candidate] (3.582 ms) : 0, 3582
section iast
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.173 ms) : 0, 1173
BytebuddyAgent [baseline] (807.54 ms) : 0, 807540
BytebuddyAgent [candidate] (798.563 ms) : 0, 798563
AgentMeter [baseline] (11.661 ms) : 0, 11661
AgentMeter [candidate] (11.343 ms) : 0, 11343
GlobalTracer [baseline] (250.174 ms) : 0, 250174
GlobalTracer [candidate] (248.632 ms) : 0, 248632
IAST [baseline] (27.608 ms) : 0, 27608
IAST [candidate] (27.182 ms) : 0, 27182
AppSec [baseline] (35.103 ms) : 0, 35103
AppSec [candidate] (34.181 ms) : 0, 34181
Debugger [baseline] (66.641 ms) : 0, 66641
Debugger [candidate] (66.985 ms) : 0, 66985
Remote Config [baseline] (546.254 µs) : 0, 546
Remote Config [candidate] (541.001 µs) : 0, 541
Telemetry [baseline] (8.747 ms) : 0, 8747
Telemetry [candidate] (8.712 ms) : 0, 8712
Flare Poller [baseline] (3.566 ms) : 0, 3566
Flare Poller [candidate] (3.508 ms) : 0, 3508
section profiling
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.165 ms) : 0, 1165
BytebuddyAgent [baseline] (681.751 ms) : 0, 681751
BytebuddyAgent [candidate] (682.56 ms) : 0, 682560
AgentMeter [baseline] (8.52 ms) : 0, 8520
AgentMeter [candidate] (8.586 ms) : 0, 8586
GlobalTracer [baseline] (215.781 ms) : 0, 215781
GlobalTracer [candidate] (216.617 ms) : 0, 216617
AppSec [baseline] (32.604 ms) : 0, 32604
AppSec [candidate] (32.708 ms) : 0, 32708
Debugger [baseline] (66.929 ms) : 0, 66929
Debugger [candidate] (67.033 ms) : 0, 67033
Remote Config [baseline] (626.858 µs) : 0, 627
Remote Config [candidate] (624.096 µs) : 0, 624
Telemetry [baseline] (8.879 ms) : 0, 8879
Telemetry [candidate] (8.875 ms) : 0, 8875
Flare Poller [baseline] (3.741 ms) : 0, 3741
Flare Poller [candidate] (3.75 ms) : 0, 3750
ProfilingAgent [baseline] (99.562 ms) : 0, 99562
ProfilingAgent [candidate] (99.461 ms) : 0, 99461
Profiling [baseline] (100.14 ms) : 0, 100140
Profiling [candidate] (100.022 ms) : 0, 100022
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~feb6c691d8, baseline=1.60.0-SNAPSHOT~969d21d507
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076082
Total [baseline] (8.748 s) : 0, 8748168
Agent [candidate] (1.065 s) : 0, 1064511
Total [candidate] (8.723 s) : 0, 8722851
section iast
Agent [baseline] (1.229 s) : 0, 1229184
Total [baseline] (9.386 s) : 0, 9386044
Agent [candidate] (1.234 s) : 0, 1234195
Total [candidate] (9.386 s) : 0, 9386303
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~feb6c691d8, baseline=1.60.0-SNAPSHOT~969d21d507
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (636.596 ms) : 0, 636596
BytebuddyAgent [candidate] (627.807 ms) : 0, 627807
AgentMeter [baseline] (29.585 ms) : 0, 29585
AgentMeter [candidate] (29.073 ms) : 0, 29073
GlobalTracer [baseline] (258.9 ms) : 0, 258900
GlobalTracer [candidate] (257.663 ms) : 0, 257663
AppSec [baseline] (33.458 ms) : 0, 33458
AppSec [candidate] (32.974 ms) : 0, 32974
Debugger [baseline] (62.599 ms) : 0, 62599
Debugger [candidate] (63.963 ms) : 0, 63963
Remote Config [baseline] (628.981 µs) : 0, 629
Remote Config [candidate] (616.904 µs) : 0, 617
Telemetry [baseline] (12.212 ms) : 0, 12212
Telemetry [candidate] (11.385 ms) : 0, 11385
Flare Poller [baseline] (4.575 ms) : 0, 4575
Flare Poller [candidate] (3.825 ms) : 0, 3825
section iast
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (794.942 ms) : 0, 794942
BytebuddyAgent [candidate] (797.832 ms) : 0, 797832
AgentMeter [baseline] (11.309 ms) : 0, 11309
AgentMeter [candidate] (11.311 ms) : 0, 11311
GlobalTracer [baseline] (247.288 ms) : 0, 247288
GlobalTracer [candidate] (247.927 ms) : 0, 247927
IAST [baseline] (26.983 ms) : 0, 26983
IAST [candidate] (27.079 ms) : 0, 27079
AppSec [baseline] (31.592 ms) : 0, 31592
AppSec [candidate] (33.231 ms) : 0, 33231
Debugger [baseline] (67.382 ms) : 0, 67382
Debugger [candidate] (66.965 ms) : 0, 66965
Remote Config [baseline] (537.754 µs) : 0, 538
Remote Config [candidate] (534.748 µs) : 0, 535
Telemetry [baseline] (8.569 ms) : 0, 8569
Telemetry [candidate] (8.685 ms) : 0, 8685
Flare Poller [baseline] (3.423 ms) : 0, 3423
Flare Poller [candidate] (3.478 ms) : 0, 3478
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~feb6c691d8, baseline=1.60.0-SNAPSHOT~969d21d507
dateFormat X
axisFormat %s
section baseline
no_agent (19.232 ms) : 19032, 19431
. : milestone, 19232,
appsec (18.792 ms) : 18599, 18986
. : milestone, 18792,
code_origins (17.937 ms) : 17758, 18117
. : milestone, 17937,
iast (17.772 ms) : 17595, 17950
. : milestone, 17772,
profiling (18.514 ms) : 18329, 18698
. : milestone, 18514,
tracing (17.856 ms) : 17677, 18035
. : milestone, 17856,
section candidate
no_agent (17.935 ms) : 17755, 18114
. : milestone, 17935,
appsec (18.461 ms) : 18275, 18648
. : milestone, 18461,
code_origins (17.689 ms) : 17515, 17863
. : milestone, 17689,
iast (17.592 ms) : 17415, 17768
. : milestone, 17592,
profiling (18.135 ms) : 17951, 18319
. : milestone, 18135,
tracing (18.126 ms) : 17947, 18305
. : milestone, 18126,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~feb6c691d8, baseline=1.60.0-SNAPSHOT~969d21d507
dateFormat X
axisFormat %s
section baseline
no_agent (1.191 ms) : 1179, 1204
. : milestone, 1191,
iast (3.204 ms) : 3162, 3247
. : milestone, 3204,
iast_FULL (5.873 ms) : 5814, 5931
. : milestone, 5873,
iast_GLOBAL (3.606 ms) : 3539, 3673
. : milestone, 3606,
profiling (2.033 ms) : 2015, 2051
. : milestone, 2033,
tracing (1.759 ms) : 1745, 1774
. : milestone, 1759,
section candidate
no_agent (1.179 ms) : 1168, 1191
. : milestone, 1179,
iast (3.0 ms) : 2962, 3039
. : milestone, 3000,
iast_FULL (5.96 ms) : 5899, 6021
. : milestone, 5960,
iast_GLOBAL (3.614 ms) : 3555, 3674
. : milestone, 3614,
profiling (1.995 ms) : 1978, 2012
. : milestone, 1995,
tracing (1.797 ms) : 1781, 1813
. : milestone, 1797,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~feb6c691d8, baseline=1.60.0-SNAPSHOT~969d21d507
dateFormat X
axisFormat %s
section baseline
no_agent (15.587 s) : 15587000, 15587000
. : milestone, 15587000,
appsec (14.683 s) : 14683000, 14683000
. : milestone, 14683000,
iast (17.842 s) : 17842000, 17842000
. : milestone, 17842000,
iast_GLOBAL (17.929 s) : 17929000, 17929000
. : milestone, 17929000,
profiling (14.912 s) : 14912000, 14912000
. : milestone, 14912000,
tracing (14.774 s) : 14774000, 14774000
. : milestone, 14774000,
section candidate
no_agent (15.004 s) : 15004000, 15004000
. : milestone, 15004000,
appsec (14.929 s) : 14929000, 14929000
. : milestone, 14929000,
iast (17.988 s) : 17988000, 17988000
. : milestone, 17988000,
iast_GLOBAL (17.795 s) : 17795000, 17795000
. : milestone, 17795000,
profiling (14.798 s) : 14798000, 14798000
. : milestone, 14798000,
tracing (14.782 s) : 14782000, 14782000
. : milestone, 14782000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~feb6c691d8, baseline=1.60.0-SNAPSHOT~969d21d507
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1492
. : milestone, 1480,
appsec (3.786 ms) : 3563, 4008
. : milestone, 3786,
iast (2.26 ms) : 2191, 2330
. : milestone, 2260,
iast_GLOBAL (2.29 ms) : 2220, 2359
. : milestone, 2290,
profiling (2.512 ms) : 2344, 2680
. : milestone, 2512,
tracing (2.075 ms) : 2021, 2129
. : milestone, 2075,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.503 ms) : 2448, 2557
. : milestone, 2503,
iast (2.254 ms) : 2185, 2323
. : milestone, 2254,
iast_GLOBAL (2.301 ms) : 2232, 2371
. : milestone, 2301,
profiling (2.066 ms) : 2012, 2120
. : milestone, 2066,
tracing (2.072 ms) : 2018, 2126
. : milestone, 2072,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Introduces unified profiling configuration constants in
ProfilingConfigand wires them through both the OpenJDK (JFR) and Datadog (ddprof) profiling controllers. Adds per-engine enable/disable settings for CPU, allocation, exception, live-heap, and latency profiling, with consistent naming (dd.profiling.<engine>.enabled) and sensible defaults. Also adds a profiler flare reporter that dumps active profiling settings for diagnostics.Motivation
Profiling settings were scattered and inconsistent between the JFR and ddprof backends — some engines could not be individually toggled, naming varied, and there was no single place to see all profiling knobs. This unification makes configuration predictable for users, easier to document, and simplifies support triage via the new flare reporter.
Additional Notes
ProfilingConfig; existing settings (heap histogram, queueing time) are unchanged.ProfilerFlareReporterexposes active settings in profiler flare output.supported-configurations.jsonupdated with new settings metadata.OpenJdkControllerandDatadogProfilerConfig.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROF-10633]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.