Skip to content

Add OctoPrint-PlotlyGraph-LYWSD03MMC plugin entry (#1)#1416

Open
yutaka551 wants to merge 1 commit intoOctoPrint:gh-pagesfrom
yutaka551:gh-pages
Open

Add OctoPrint-PlotlyGraph-LYWSD03MMC plugin entry (#1)#1416
yutaka551 wants to merge 1 commit intoOctoPrint:gh-pagesfrom
yutaka551:gh-pages

Conversation

@yutaka551
Copy link

@yutaka551 yutaka551 commented Feb 22, 2026

  • Add OctoPrint-PlotlyGraph-LYWSD03MMC plugin entry
  • You have read the "Registering a new Plugin" guide.
  • You want to and are able to maintain the plugin you are registering, long-term.
  • You understand why the plugin you are registering works.
  • You have read and acknowledge the Code of Conduct.

What is the name of your plugin?

What does your plugin do?

Where can we find the source code of your plugin?

Was any kind of genAI (ChatGPT, Copilot etc) involved in creating this plugin?

Is your plugin commercial in nature?

Does your plugin rely on some cloud services?

Further notes

* Add OctoPrint-PlotlyGraph-LYWSD03MMC plugin entry
Copilot AI review requested due to automatic review settings February 22, 2026 07:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new plugin entry for OctoPrint-PlotlyGraph-LYWSD03MMC, which integrates Xiaomi Mijia LYWSD03MMC Bluetooth temperature and humidity sensors with the OctoPrint PlotlyTempGraph plugin.

Changes:

  • Added new plugin metadata file for plotly_graph_lywsd03mmc plugin with complete configuration and documentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jacopotediosi
Copy link
Contributor

@yutaka551 Can you please fill the PR template?

@jneilliii
Copy link
Contributor

jneilliii commented Feb 22, 2026

I can tell what it is because it integrates with my PlotlyTempGraph plugin (obviously copilot is involved). The functionality I can tell will work purely based on the programming logic, but there are issues with plugin:

  • importing the library every time it goes to read the sensor here rather than just a simple import with the rest at top to initialize on load. the module is defined in plugin_requires so no need for the whole try/catch block for the ImportError here
  • software update here return doesn't match plugin identifier defined here.
  • missing plugin author email
  • using old setup.py method rather than newer pyproject.toml used in current cookiecutter template
  • not actually an issue, but version defined here and in setup.py, make sure to update both places in future updates or it will cause update loops.
  • do you even need the AssetPlugin if you're not actually returning anything, this whole block could be removed and this line.

@yutaka551
Copy link
Author

Thank you very much for your thorough review and comments. You are absolutely right, and I will make the
necessary changes. I learned a great deal—thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants