WWSTCERT-10511/WWSTCERT-10514 Add support to frient smoke co sensor#2776
Open
marcintyminski wants to merge 9 commits intoSmartThingsCommunity:mainfrom
Open
WWSTCERT-10511/WWSTCERT-10514 Add support to frient smoke co sensor#2776marcintyminski wants to merge 9 commits intoSmartThingsCommunity:mainfrom
marcintyminski wants to merge 9 commits intoSmartThingsCommunity:mainfrom
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 72 files 487 suites 0s ⏱️ Results for commit 4123a75. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 4123a75 |
greens
reviewed
Feb 27, 2026
| @@ -0,0 +1,15 @@ | |||
| -- Copyright 2025 SmartThings, Inc. | |||
greens
reviewed
Feb 27, 2026
Comment on lines
+123
to
+125
| local function do_refresh(driver, device) | ||
| device:refresh() | ||
| end |
greens
reviewed
Feb 27, 2026
Comment on lines
+34
to
+41
| { | ||
| cluster = IASZone.ID, | ||
| attribute = IASZone.attributes.ZoneStatus.ID, | ||
| minimum_interval = 0, | ||
| maximum_interval = 300, | ||
| data_type = IASZone.attributes.ZoneStatus.base_type, | ||
| reportable_change = 1 | ||
| }, |
Contributor
There was a problem hiding this comment.
Doesn't seem necessary to overwrite the default config here
greens
reviewed
Feb 27, 2026
| end | ||
|
|
||
| local function ias_zone_status_attr_handler(driver, device, zone_status, zb_rx) | ||
| generate_event_from_zone_status(driver, device, zone_status, zb_rx) |
Contributor
There was a problem hiding this comment.
you can just use generate_event_from_zone_status rather than creating this extra function
greens
reviewed
Feb 27, 2026
| local input = device.preferences.maxWarningDuration | ||
| device:send(IASWD.attributes.MaxDuration:write(device, input)) | ||
| end | ||
| if (name == "temperatureSensitivity") then |
greens
reviewed
Feb 27, 2026
Comment on lines
+4
to
+26
| local capabilities = require "st.capabilities" | ||
| local zcl_clusters = require "st.zigbee.zcl.clusters" | ||
| local data_types = require "st.zigbee.data_types" | ||
| local IASZone = zcl_clusters.IASZone | ||
| local CarbonMonoxideCluster = zcl_clusters.CarbonMonoxide | ||
| local carbonMonoxide = capabilities.carbonMonoxideDetector | ||
| local CarbonMonoxideEndpoint = 0x2E | ||
| local SmokeAlarmEndpoint = 0x23 | ||
| local TemperatureMeasurement = zcl_clusters.TemperatureMeasurement | ||
| local TEMPERATURE_ENDPOINT = 0x26 | ||
| local alarm = capabilities.alarm | ||
| local smokeDetector = capabilities.smokeDetector | ||
| local IASWD = zcl_clusters.IASWD | ||
| local carbonMonoxideMeasurement = capabilities.carbonMonoxideMeasurement | ||
| local tamperAlert = capabilities.tamperAlert | ||
| local SirenConfiguration = IASWD.types.SirenConfiguration | ||
| local battery_defaults = require "st.zigbee.defaults.battery_defaults" | ||
| local SinglePrecisionFloat = require "st.zigbee.data_types.SinglePrecisionFloat" | ||
| local ALARM_COMMAND = "alarmCommand" | ||
| local ALARM_DURATION = "warningDuration" | ||
| local DEFAULT_MAX_WARNING_DURATION = 0x00F0 | ||
| local zcl_global_commands = require "st.zigbee.zcl.global_commands" | ||
| local Status = require "st.zigbee.generated.types.ZclStatus" |
Contributor
There was a problem hiding this comment.
For ease of reading, can you separate out the device-specific constants here from the library imports?
greens
changed the title
greens
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests