fix(enterprise): support virtual hosted and path-style S3 endpoints#15418
Open
geidsonc wants to merge 1 commit intoanomalyco:devfrom
Open
fix(enterprise): support virtual hosted and path-style S3 endpoints#15418geidsonc wants to merge 1 commit intoanomalyco:devfrom
geidsonc wants to merge 1 commit intoanomalyco:devfrom
Conversation
- Add OPENCODE_STORAGE_ENDPOINT env var for custom S3-compatible services - Detect endpoint format (virtual hosted vs path style) automatically - Add service: "s3" to AwsClient for S3-compatible providers
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
bot
removed
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #7808
Type of change
What does this PR do?
The enterprise package storage for /share API only supported path-style S3 URLs. This caused issues with S3-compatible providers that use virtual hosted-style URLs.
Then this PR add support for virtual hosted style for S3 providers and maintains current support for path-style.
The changes:
OPENCODE_STORAGE_ENDPOINTenvironment variable to allow custom S3 endpointsHow did you verify your code works?
You should test locally with your S3 provider using virtual hosted-style endpoint
Screenshots / recordings
Checklist