Ignore DuplicateRootAssembly during debug builds. #124970
Open
mrvoorhe wants to merge 1 commit intodotnet:mainfrom
Open
Ignore DuplicateRootAssembly during debug builds. #124970mrvoorhe wants to merge 1 commit intodotnet:mainfrom
DuplicateRootAssembly during debug builds. #124970mrvoorhe wants to merge 1 commit intodotnet:mainfrom
Conversation
… Debug.Assert leading to a failure.
Contributor
Author
|
@sbomer please take a look |
github-actions
bot
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
linkable-framework
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/illink |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents the DuplicateRootAssembly test from running in DEBUG builds to avoid triggering a Debug.Assert that would cause test failures. The test case is designed to validate duplicate root assembly handling by passing the same assembly via different paths, which triggers assertions in debug-enabled builds.
Changes:
- Conditionally skip
DuplicateRootAssemblytest in DEBUG builds using#if DEBUGpreprocessor directive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will trigger a Debug.Assert leading to a failure.