Added my first doubt#562
Open
Manikantasai1724 wants to merge 3 commits intofirstcontributions:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the contributor documentation, but the added line appears to be a personal note/question rather than actionable guidance for repository contributors.
Changes:
- Adds a new sentence at the end of
CONTRIBUTING.md.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CONTRIBUTING.md
Outdated
Comment on lines
+44
to
+45
| ` | ||
| can we put your own github username in this file. No newline at end of file |
There was a problem hiding this comment.
The added line reads like an open question and is ungrammatical/unclear for a CONTRIBUTING guide. Either remove it, or rephrase it as an instruction (e.g., tell readers to replace <github_username> with their GitHub username). Also capitalize “GitHub”.
Suggested change
| ` | |
| can we put your own github username in this file. | |
| ` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first comprehensive procedure that I fully understand regarding push and pull requests.