fix(languages/analyzer): TypeError on null committer by ferferga · Pull Request #21 · gh-metrics/metrics

ferferga · 2026-01-29T20:04:05Z

First of all, thank you very much for trying to keep this project active.

In the old version (and in this one), I'm receiving this error at the rendering stage:

TypeError: Cannot destructure property 'committer' of 'undefined' as it is undefined.
    at file:///metrics/source/plugins/languages/analyzer/recent.mjs:70:21
    at Array.filter (<anonymous>)
    at RecentAnalyzer.patches (file:///metrics/source/plugins/languages/analyzer/recent.mjs:70:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async RecentAnalyzer.analyze (file:///metrics/source/plugins/languages/analyzer/recent.mjs:25:21)
    at async file:///metrics/source/plugins/languages/analyzer/recent.mjs:19:7
    at async results (file:///metrics/source/plugins/languages/analyzer/analyzer.mjs:64:7)
Node.js v20.20.0

This pull request fixes the issue.

Copilot

Pull request overview

Fixes a crash in the languages “recently-used” analyzer when processing PushEvent commit entries that are undefined or have missing committer data.

Changes:

Hardened PushEvent commit filtering to avoid destructuring committer from an undefined commit.
Added an explicit guard for commit.committer.email before applying the authoring filter.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-29T20:09:25Z

source/plugins/languages/analyzer/recent.mjs

        commits
          .flatMap(({payload}) => payload.commits)
-          .filter(({committer}) => filters.text(committer?.email, this.authoring, {debug: false}))
+          .filter(commit => commit?.committer?.email && filters.text(commit.committer.email, this.authoring, {debug: false}))


The new filter still uses filters.text(...), which returns true when the value is not in the patterns list. Given commits_authoring is documented/used elsewhere as the set of identifiers to match (e.g., code plugin filters commits where author matches an entry), this likely inverts the intent and can exclude the user’s own commits when commit.committer.email is present. Consider aligning with the other commit-authoring filters by treating commits_authoring as an inclusion match (or explicitly negating filters.text if you want exact-match semantics).

Suggested change

.filter(commit => commit?.committer?.email && filters.text(commit.committer.email, this.authoring, {debug: false}))

.filter(commit => commit?.committer?.email && !filters.text(commit.committer.email, this.authoring, {debug: false}))

Copilot · 2026-01-29T20:09:25Z

source/plugins/languages/analyzer/recent.mjs

        commits
          .flatMap(({payload}) => payload.commits)
-          .filter(({committer}) => filters.text(committer?.email, this.authoring, {debug: false}))
+          .filter(commit => commit?.committer?.email && filters.text(commit.committer.email, this.authoring, {debug: false}))


This fixes a runtime TypeError for malformed PushEvent commit entries, but there’s no automated coverage for the specific edge case (e.g., payload.commits containing undefined/null or commits missing committer). Since there is an existing languages plugin test case for the “recently-used” section, consider extending the GitHub activity mock to include such an entry so the regression is caught.

lishaduck · 2026-01-31T05:36:30Z

Are they really forcing copilot reviews on everybody these days? That sucks.

This looks fine but there's like 20 equivalent PRs in the lowlighter repo and I want to attribute it correctly.
I'll leave this open as a reminder for me to do that (I'll add you as a coauthor)

ferferga · 2026-02-03T00:19:00Z

Oops, kwoning it was unmaintained, I didn't even bother checking the original repo. I will leave the related PRs listed here for reference to future people coming across this thread, feel free to add more @lishaduck. I will also edit this comment if I find more

WIP: Fix recent languages after GitHub API change (Cannot destructure property 'committer' of 'undefined') lowlighter/metrics#1754
Fix: Cannot destructure property 'author' of 'undefined' lowlighter/metrics#1739

lishaduck · 2026-02-03T00:54:49Z

Oops, kwoning it was unmaintained, I didn't even bother checking the original repo.

Nah, you're good! I just keep directing people over there to file over here so I'd feel bad not giving them credit.
I'll try to get them merged in tonight or tomorrow 🤞🏻, pls remind me if I forget!

Signed-off-by: Fernando Fernández <ferferga@hotmail.com>

ferferga · 2026-02-24T16:05:17Z

@lishaduck Any news about this?

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-24T16:10:15Z

source/plugins/lines/index.mjs

      //Compute changes
      repos[handle] = {added: 0, deleted: 0, changed: 0}
-      const contributors = stats.filter(({author}) => (context.mode === "repository") || (context.mode === "organization") ? true : author?.login?.toLocaleLowerCase() === login.toLocaleLowerCase())
+      const contributors = stats.filter(contributors => contributors && ((context.mode === "repository") || (context.mode === "organization") ? true : contributors.author?.login?.toLocaleLowerCase() === login.toLocaleLowerCase()))


The PR title/description focuses on the languages recent analyzer TypeError, but this PR also changes the lines plugin contributor filtering/logging. If this is intentional (same class of undefined entries), consider mentioning it in the PR description so reviewers understand the additional scope.

Copilot · 2026-02-24T16:10:15Z

source/plugins/lines/index.mjs

      //Compute changes
      repos[handle] = {added: 0, deleted: 0, changed: 0}
-      const contributors = stats.filter(({author}) => (context.mode === "repository") || (context.mode === "organization") ? true : author?.login?.toLocaleLowerCase() === login.toLocaleLowerCase())
+      const contributors = stats.filter(contributors => contributors && ((context.mode === "repository") || (context.mode === "organization") ? true : contributors.author?.login?.toLocaleLowerCase() === login.toLocaleLowerCase()))


The stats.filter(contributors => ...) callback parameter name (contributors) is plural and also very close to the outer contributors array constant, which makes this line harder to read and easier to mis-edit later. Rename the callback parameter to contributor (or similar) to avoid shadowing/confusion.

Suggested change

const contributors = stats.filter(contributors => contributors && ((context.mode === "repository") || (context.mode === "organization") ? true : contributors.author?.login?.toLocaleLowerCase() === login.toLocaleLowerCase()))

const contributors = stats.filter(contributor => contributor && ((context.mode === "repository") || (context.mode === "organization") ? true : contributor.author?.login?.toLocaleLowerCase() === login.toLocaleLowerCase()))

lishaduck · 2026-02-24T16:31:31Z

@lishaduck Any news about this?

Oh, yup. I've been really busy the last week or two, but I'll see if I can fit in the time to review this 👍🏻
Thanks for your patience!

Copilot AI review requested due to automatic review settings January 29, 2026 20:04

github-actions bot added 🧩 plugins 🈷️ plugin languages labels Jan 29, 2026

Copilot started reviewing on behalf of ferferga January 29, 2026 20:04 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

ferferga force-pushed the fix-null-committer branch from 0d638c8 to 441b468 Compare January 30, 2026 00:55

github-actions bot added the 👨‍💻 plugin lines label Jan 30, 2026

ferferga force-pushed the fix-null-committer branch 2 times, most recently from db4a56e to aaff3b5 Compare February 24, 2026 16:03

fix(languages/analyzer): TypeError on null committer

bcc79f0

Signed-off-by: Fernando Fernández <ferferga@hotmail.com>

ferferga force-pushed the fix-null-committer branch from aaff3b5 to bcc79f0 Compare February 24, 2026 16:05

ferferga requested a review from Copilot February 24, 2026 16:05

Copilot started reviewing on behalf of ferferga February 24, 2026 16:06 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(languages/analyzer): TypeError on null committer#21

fix(languages/analyzer): TypeError on null committer#21
ferferga wants to merge 1 commit intogh-metrics:masterfrom
ferferga:fix-null-committer

ferferga commented Jan 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 29, 2026

Uh oh!

Copilot AI Jan 29, 2026

Uh oh!

lishaduck commented Jan 31, 2026

Uh oh!

ferferga commented Feb 3, 2026

Uh oh!

lishaduck commented Feb 3, 2026

Uh oh!

ferferga commented Feb 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

lishaduck commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	.filter(commit => commit?.committer?.email && filters.text(commit.committer.email, this.authoring, {debug: false}))
	.filter(commit => commit?.committer?.email && !filters.text(commit.committer.email, this.authoring, {debug: false}))

	const contributors = stats.filter(contributors => contributors && ((context.mode === "repository") \|\| (context.mode === "organization") ? true : contributors.author?.login?.toLocaleLowerCase() === login.toLocaleLowerCase()))
	const contributors = stats.filter(contributor => contributor && ((context.mode === "repository") \|\| (context.mode === "organization") ? true : contributor.author?.login?.toLocaleLowerCase() === login.toLocaleLowerCase()))

Conversation

ferferga commented Jan 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

lishaduck commented Jan 31, 2026

Uh oh!

ferferga commented Feb 3, 2026

Uh oh!

lishaduck commented Feb 3, 2026

Uh oh!

ferferga commented Feb 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

lishaduck commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants