fix: premature milestone complete when phases lack directories (#754)#801
Open
ethan-hurst wants to merge 1 commit intogsd-build:mainfrom
Open
fix: premature milestone complete when phases lack directories (#754)#801ethan-hurst wants to merge 1 commit intogsd-build:mainfrom
ethan-hurst wants to merge 1 commit intogsd-build:mainfrom
Conversation
…mplete (gsd-build#754) phase complete and init milestone-op only counted phase directories, missing phases defined in the ROADMAP that hadn't been planned yet. This caused premature "milestone complete" status after executing earlier phases when later phases had no directories. Now falls back to parsing ROADMAP.md headings when no next directory is found, correctly detecting remaining unplanned phases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
phase completeandinit milestone-opto check ROADMAP.md for phases that haven't been planned yet (no directories), preventing premature "milestone complete" status.Why
Phases defined in the ROADMAP but not yet planned have no
.planning/phases/directory. Both commands only counted directories, so completing phase 9 of a 13-phase milestone would report "milestone complete" because phases 10-13 had no directories yet. Fixes #754.Testing
Regression tests added:
phase complete: 4-phase ROADMAP with only 2 directories — completing phase 9 correctly reportsis_last_phase: falseandnext_phase: 10init milestone-op: 4-phase ROADMAP with 2 completed directories — correctly reportsphase_count: 4,all_phases_complete: falseFull suite: 434/434 passing (432 existing + 2 new)
Checklist
Breaking Changes
None