chore(deps): revert stencil to version 4.33.1#30707
Merged
rugoncalves merged 1 commit intonextfrom Oct 7, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rugoncalves
changed the title
4.33.1
ShaneK
approved these changes
Oct 7, 2025
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
I'm generally against this, but I'm approving because I understand it's a temporary requirement to bypass an issue until more time can be spent investigating the cause of your issues later.
brandyscarney
changed the title
2 tasks
OS-giulianasilva
added a commit
that referenced
this pull request
Oct 28, 2025
Issue number: resolves internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? - The Stencil version was previously reverted under #30707 because of test failures of components form another repo. ## What is the new behavior? - Update the version again to match what we have in main, since these tests were fixed. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #
What is the current behavior?
The current version in use of stencil (
4.36.2), as well as, a more recent version (4.38.0) are breaking the tests for several of the components (e.g. accordion, datepicker, modal)What is the new behavior?
4.33.1Does this introduce a breaking change?
Other information
N/A