Skip to content

feat(item-divider): add inner and container parts#30928

Merged
brandyscarney merged 6 commits intofeature-8.8from
FW-6794-item-divider
Feb 27, 2026
Merged

feat(item-divider): add inner and container parts#30928
brandyscarney merged 6 commits intofeature-8.8from
FW-6794-item-divider

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jan 19, 2026

Issue number: N/A


What is the current behavior?

The inner structural elements of item-divider are not exposed as shadow parts, preventing users from being able to customize their styles directly.

What is the new behavior?

  • Exposes inner and container shadow parts
  • Adds e2e test coverage for customizing the shadow parts

Does this introduce a breaking change?

  • Yes
  • No

@vercel
Copy link

vercel bot commented Jan 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ionic-framework Ready Ready Preview, Comment Feb 27, 2026 4:20pm

Request Review

@brandyscarney brandyscarney marked this pull request as ready for review January 20, 2026 15:33
@brandyscarney brandyscarney requested a review from a team as a code owner January 20, 2026 15:33
@brandyscarney brandyscarney requested a review from ShaneK January 20, 2026 15:33
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits, feel free to disregard if you want. Looks good to me!

@ShaneK
Copy link
Member

ShaneK commented Feb 27, 2026

BTW I think the title of this PR should be add inner and container parts and your description should be updated to match

@brandyscarney brandyscarney changed the title feat(item-divider): add inner and content parts feat(item-divider): add inner and container parts Feb 27, 2026
@brandyscarney brandyscarney merged commit 5cdeb7f into feature-8.8 Feb 27, 2026
49 checks passed
@brandyscarney brandyscarney deleted the FW-6794-item-divider branch February 27, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants