fix(invite): decode dial-in room name consistently#16977
fix(invite): decode dial-in room name consistently#16977nishant25kr wants to merge 1 commit intojitsi:masterfrom
Conversation
|
Fixes #16958 |
|
Hi, thanks for your contribution! |
|
Thanks for the heads-up! |
|
What will happen if room has some of the symbols in the name ... This may change the name? |
|
Good questions, thanks for raising them. Symbols in room names Double encoding |
|
It is better first fix the root cause of this and then check is this needed and avoid adding complexity that may break stuff later. |
|
if it is possible can you suggest me how can i approach the root cause of this problem. |
DreaserousProductions
left a comment
There was a problem hiding this comment.
The change aptly handles the issue at hand.
In case a URL is decoded multiple times, the completely decoded Room Name is returned.
If the URL is malformed or it is already decoded, the fix will retain the original Room Name.
Note: The issue of room names appearing with no spaces is not addressed. The cause is believed to not be in this portion of the codebase.
When creating the more numbers link it should behave correctly and decode the name. |
|
For example the copy link thingy is already doing it correctly. |
What
Ensure the dial-in info page displays a human-readable room name when the
roomquery parameter is URL-encoded multiple times.Why
When opening the dial-in page from desktop/Electron clients, the room name can
arrive double-encoded (e.g.
%2520). The page previously decoded only once,causing
%20to appear in the UI.How
decodeURIComponentcall with the helperThis keeps the display consistent across web and desktop entry points.