fix(auth): prevent JWT token credential leakage via URL query params and server logs#17047
Open
onlybugs05-hackerone wants to merge 5 commits intojitsi:masterfrom
Open
fix(auth): prevent JWT token credential leakage via URL query params and server logs#17047onlybugs05-hackerone wants to merge 5 commits intojitsi:masterfrom
onlybugs05-hackerone wants to merge 5 commits intojitsi:masterfrom
Conversation
… authentication via URL query parameters by default, and remove app shortcuts.
…and server logs Co-authored-by: onlybugs05-hackerone <257578503+onlybugs05-hackerone@users.noreply.github.com>
…k-vulnerability fix(auth): prevent JWT token credential leakage via URL query params and server logs
|
Hi, thanks for your contribution! |
Author
|
Yah I have already Done it ! |
Member
|
Have you tested this with the client? |
damencho
requested changes
Feb 28, 2026
Member
damencho
left a comment
There was a problem hiding this comment.
Thes reauires client changes
Author
|
Yah they do required client changes. BUt Its Better to Stop That to for security Purposes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JWT tokens were exposed in server logs (CWE-532) and URL query strings (CWE-598) in the Prosody auth modules, risking credential leakage via access logs, browser history, and Referer headers.
Changes
mod_token_verification.lua— Removesession.auth_tokenfrom the error log inverify_user(). The raw JWT was being written to error logs on every failed room join:mod_jitsi_session.lua— Token extraction from URL query parameters is already blocked by default (accept_token_from_query = false). Add a module-load warning when this opt-in is explicitly enabled so administrators are aware of the accepted risk: