feat(cli): add localizableKeys config option to bypass untranslatable…#2004
Merged
AndreyHirsa merged 1 commit intomainfrom Feb 23, 2026
Merged
feat(cli): add localizableKeys config option to bypass untranslatable…#2004AndreyHirsa merged 1 commit intomainfrom
AndreyHirsa merged 1 commit intomainfrom
Conversation
Contributor
📝 WalkthroughWalkthroughA new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
cherkanovart
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
localizableKeysbucket config option to force‑translate values that would otherwise be auto‑skipped by the untranslatable filter (e.g., pure numbers, URLs, ISO dates).Changes
localizableKeys: string[]on bucket config.localizableKeysthrough all 33 bucket types in the loader pipeline and all 10createBucketLoadercall sites.matchesKeyPatternfor matching — supports exact, prefix, and glob patterns (consistent withlockedKeys,ignoredKeys,preservedKeys).encodeKeysforxcode-xcstringsvariants andnormalizeCsvPatternsforcsv-per-locale(consistent with other key configs).Testing
Business logic tests added:
"config/count"matches flattened nested objects."config"matches all keys underconfig/."*/count"matchescountat any level.Visuals
N/A - no UI changes.
Checklist
localizableKeysis optional, existing configs unaffected.Summary by CodeRabbit
Release Notes
localizableKeysbucket configuration option to force translation of specific values that would normally be excluded (such as numbers, URLs, and dates). This enhancement ensures custom translation rules can be applied to these previously skipped values.