<optional>: Add Address Sanitizer annotations#6010
<optional>: Add Address Sanitizer annotations#6010ozguronsoy wants to merge 8 commits intomicrosoft:mainfrom
<optional>: Add Address Sanitizer annotations#6010Conversation
|
@microsoft-github-policy-service agree |
<optional>: Add Address Sanitizer annotations
This comment was marked as resolved.
This comment was marked as resolved.
| #endif | ||
| } // extern "C" | ||
|
|
||
| #if defined(_INSERT_VECTOR_ANNOTATION) || defined(_INSERT_STRING_ANNOTATION) |
There was a problem hiding this comment.
I think there should be a concentrated controlling macro for these.
There was a problem hiding this comment.
I don't think it's necessary since this check is only done here. I also added defined(_INSERT_OPTIONAL_ANNOTATION) to the check.
297ab67 to
1be4772
Compare
|
Hi @StephanTLavavej, since the |
|
Yes, I'm trying to get through my PR review backlog. I know you've been waiting a month, for which I apologize. I'm the only maintainer flying this jumbo jet at the moment, so I ask for your patience! |
|
Wow that must be tough. It's no problem, I can wait. |
davidmrdavid
left a comment
There was a problem hiding this comment.
Left some very minor feedback. The implementation seems sound, but from comparing the test matrix to the one in the asan vector and asan string annotations, I suspect we'll need a few more scenarios. I'll defer to @StephanTLavavej as usual.
When
optionalis empty the internal storage is poisoned, it's unpoisoned when a value is assigned._ANNOTATE_OPTIONAL,_DISABLE_OPTIONAL_ANNOTATION, etc. to__msvc_sanitizer_annotate_container.hpp._Optional_destruct_baseon empty construction andreset._Optional_construct_base::_Construct.Resolves #5974