Skip to content

Making the whitespaces align vertically with variable font text#298252

Draft
aiday-mar wants to merge 2 commits intomainfrom
religious-crawdad
Draft

Making the whitespaces align vertically with variable font text#298252
aiday-mar wants to merge 2 commits intomainfrom
religious-crawdad

Conversation

@aiday-mar
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings February 27, 2026 14:11
@aiday-mar aiday-mar self-assigned this Feb 27, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts editor whitespace rendering so that whitespace markers are rendered via the experimental whitespace overlay even on lines that contain variable-font-affecting decorations, improving alignment with the actual rendered text.

Changes:

  • Enable WhitespaceOverlay rendering for lines flagged with lineData.hasVariableFonts (remove the early-return skip).
  • Ensure view-line DOM rendering does not render whitespace when experimentalWhitespaceRendering !== 'off', regardless of hasVariableFonts, so the overlay is the single whitespace-rendering mechanism in experimental modes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/vs/editor/browser/viewParts/whitespace/whitespace.ts Removes the variable-font short-circuit so the overlay can render whitespace markers on those lines.
src/vs/editor/browser/viewParts/viewLines/viewLine.ts Simplifies the whitespace rendering decision so experimental modes always delegate whitespace rendering to the overlay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants