Updating the edit context on content change not on lines inserted, deleted and changed#298272
Conversation
…leted and changed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue with NativeEditContext updates by switching from view-layer events to model-layer events for detecting content changes. The change improves reliability by listening directly to model content changes rather than relying on view events that may not fire in all scenarios.
Changes:
- Added
onDidChangeContentmodel event handler to detect content changes and update EditContext when changes overlap with the current selection - Removed the
_updateEditContextOnLineChangehelper method that was called from view event handlers - Simplified
onLinesChanged,onLinesDeleted, andonLinesInsertedview event handlers to just returntrue(still needed for rendering)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/microsoft/vscode-internalbacklog/issues/6926