Terminal sandboxing errors out when trusted domains are urls instead of domains.#298372
Merged
dileepyavan merged 3 commits intomainfrom Feb 28, 2026
Merged
Terminal sandboxing errors out when trusted domains are urls instead of domains.#298372dileepyavan merged 3 commits intomainfrom
dileepyavan merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes terminal sandbox network configuration generation when allowTrustedDomains is enabled and entries in the Trusted Domains list are full URLs (not bare domains), by normalizing trusted domain entries before writing the sandbox settings file.
Changes:
- Refactors allowed domain construction to optionally merge trusted domains via a helper.
- Adds URL parsing to extract
hostnamefrom trusted domain entries that are full URLs.
src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalSandboxService.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalSandboxService.ts
Show resolved
Hide resolved
roblourens
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes(#298332)
Terminal sandboxing is broken when AllowTrustedDomains flag is set to true and trusted domains contains Urls instead of just domains.