Fix session resource aliasing in chat sessions#298374
Merged
TylerLeonhardt merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
Member
Author
|
FYI @mjbvz |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds session-resource aliasing to the chat sessions infrastructure so that when an untitled session is later resolved to a “real” session resource, session-option lookups continue to work against the canonical resource stored in the internal session map.
Changes:
- Extend
IChatSessionsServicewithregisterSessionResourceAlias(untitledResource, realResource)for redirecting option lookups. - Implement alias resolution in
ChatSessionsServicefor session-option getters/setters and option-change notifications. - Update
MainThreadChatAgents2to register an alias when an untitled session is resolved vianewChatSessionItemHandlerand update the model’s contributed session resource.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/common/mockChatSessionsService.ts | Adds the new interface method as a no-op in the mock implementation. |
| src/vs/workbench/contrib/chat/common/chatSessionsService.ts | Adds the alias-registration API to IChatSessionsService. |
| src/vs/workbench/contrib/chat/browser/chatSessions/chatSessions.contribution.ts | Implements alias mapping and resolves option lookups + option-change events through the alias map. |
| src/vs/workbench/api/browser/mainThreadChatAgents2.ts | Registers aliases when resolving untitled sessions to real resources, and updates the contributed session metadata. |
src/vs/workbench/contrib/chat/browser/chatSessions/chatSessions.contribution.ts
Show resolved
Hide resolved
eleanorjboyd
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a mechanism to register aliases for session resources, allowing session-option lookups to redirect to the correct canonical resource. This change enhances the handling of chat sessions by ensuring that the correct resources are used in session management.
I think this is pretty fragile, but it fixes the critical issues that need to be fixed this release.
ref #298378