feat: add --spec-version option to tier-check#176
Open
DePasqualeOrg wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
feat: add --spec-version option to tier-check#176DePasqualeOrg wants to merge 1 commit intomodelcontextprotocol:mainfrom
DePasqualeOrg wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Allows filtering conformance scenarios by target spec version, so SDKs are only scored against scenarios applicable to the version they target. This prevents legacy backward-compatibility scenarios from counting against SDKs that don't claim legacy support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK tiering requirements state that conformance scores should be calculated against applicable tests only, "excluding legacy backward-compatibility tests (unless the SDK claims legacy support)."
Currently,
tier-checkruns all scenarios regardless of the spec version the SDK targets. For example, an SDK targeting2025-11-25is scored against2025-03-26-only backward-compatibility scenarios (auth/2025-03-26-oauth-metadata-backcompat,auth/2025-03-26-oauth-endpoint-fallback), even though those are legacy tests.Fix
Add a
--spec-version <version>option totier-checkthat:--spec-versionthrough to theconformance serverandconformance clientCLI invocations, so only matching scenarios are executed.reconcileWithExpected, so excluded scenarios aren't counted as failures.Usage
npx @modelcontextprotocol/conformance tier-check \ --repo owner/sdk \ --conformance-server-url http://localhost:8080/mcp \ --client-cmd "./conformance-client" \ --spec-version 2025-11-25Testing
Ran
tier-checkagainst my Swift SDK with--spec-version 2025-11-25:2025-03-26-only backward-compat auth scenariosBreaking Changes
None
Types of changes
Checklist
I have added appropriate error handling(n.a.)I have added or updated documentation as needed(n.a.)