fix(windows): ensure DLLs can always be located by PHP#2227
Open
fix(windows): ensure DLLs can always be located by PHP#2227
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves FrankenPHP’s Windows startup behavior so PHP can reliably locate and load extensions/DLL dependencies when php.ini uses relative paths and FrankenPHP is launched with a different working directory (e.g., caddy start).
Changes:
- On Windows, derives the FrankenPHP module directory at startup and sets it as the DLL search directory before PHP startup proceeds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Use a 32K buffer instead of MAX_PATH to support long module paths, and check SetDllDirectoryW return value, logging on failure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
henderkes
reviewed
Mar 1, 2026
Contributor
|
Looks good on mobile now, but I'll give it a proper review in a few days on my laptop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent crashes when
php.inireferences PHP extensions using relative paths, and FrankenPHP is started from a different working directory than the one containing extensions, or withcaddy start(instead ofcaddy run).