Conversation
There was a problem hiding this comment.
Pull request overview
Adds Windows support to the existing install flow by updating install.sh to download/extract the Windows ZIP when running under common Windows POSIX layers (MSYS/Cygwin/MinGW), and introduces a native PowerShell installer script for Windows users.
Changes:
- Update
install.shto download the latest Windows x64 ZIP asset and extract it intoBIN_DIR. - Add
install.ps1to download the latest Windows release ZIP via GitHub API and extract it to a chosen directory.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| install.sh | Adds a Windows-specific branch to download and extract the latest Windows ZIP asset. |
| install.ps1 | New PowerShell installer that fetches the latest Windows ZIP asset and expands it to BIN_DIR (or current directory). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
install.ps1
Outdated
| $tmpZip = Join-Path $env:TEMP "frankenphp-windows-$PID.zip" | ||
|
|
||
| try { | ||
| Invoke-WebRequest -Uri $asset.browser_download_url -OutFile $tmpZip -UseBasicParsing |
There was a problem hiding this comment.
Invoke-WebRequest -UseBasicParsing will fail in PowerShell 6+/7+ because that parameter was removed, and #Requires -Version 5.1 still allows newer PowerShell versions. Consider removing -UseBasicParsing or only using it when running on Windows PowerShell 5.1.
| Invoke-WebRequest -Uri $asset.browser_download_url -OutFile $tmpZip -UseBasicParsing | |
| Invoke-WebRequest -Uri $asset.browser_download_url -OutFile $tmpZip |
Update the shell script and add a PowerShell script to install the Windows binary.