fix: match GNU error format for unrecognized options#180
Open
Ryujiyasu wants to merge 2 commits intouutils:mainfrom
Open
fix: match GNU error format for unrecognized options#180Ryujiyasu wants to merge 2 commits intouutils:mainfrom
Ryujiyasu wants to merge 2 commits intouutils:mainfrom
Conversation
Use single quotes and remove colon to match GNU diff/cmp output: `unrecognized option '--foobar'` instead of `unrecognized option: "--foobar"` Also use `contains` instead of `starts_with` in the integration test to handle the command prefix (e.g. `cmp: unrecognized option ...`). Follow-up to uutils#178 / uutils#179. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #178 / #179. Adjusts the unrecognized option error message to match the actual GNU diff/cmp output format:
unrecognized option'--foobar'instead of"--foobar")containsinstead ofstarts_within integration test to handle the command prefix (e.g.cmp: unrecognized option ...)Before:
unrecognized option: "--foobar"After:
unrecognized option '--foobar'As pointed out by @GunterSchmidt in #178 (comment).
Test plan
cargo test— all 125 unit tests and 21 integration tests passdiffutils diff --foobaroutputsunrecognized option '--foobar'diffutils cmp --foobaroutputsunrecognized option '--foobar'