Conversation
Signed-off-by: Takuma IMAMURA <209989118+hyperfinitism@users.noreply.github.com>
…e consistent look.
There was a problem hiding this comment.
Pull request overview
This PR appears to remove a large set of bundled extensions and their related sources/configuration, and adjusts repo-level build/devcontainer configuration.
Changes:
- Removes many extension source trees, tests, and packaging/build config files (Emmet, CSS language features, and multiple “language basics” extensions).
- Updates the devcontainer configuration (remote user + feature set).
- Adds a repo-level npm config intended to force C++20 when compiling native Node modules.
Reviewed changes
Copilot reviewed 191 out of 2210 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| extensions/emmet/src/test/index.ts | Removed Emmet integration test runner entrypoint |
| extensions/emmet/src/test/incrementDecrement.test.ts | Removed Emmet increment/decrement integration tests |
| extensions/emmet/src/test/evaluateMathExpression.test.ts | Removed Emmet math evaluation integration tests |
| extensions/emmet/src/test/completion.test.ts | Removed Emmet completion integration tests |
| extensions/emmet/src/splitJoinTag.ts | Removed Emmet split/join tag command implementation |
| extensions/emmet/src/selectItemStylesheet.ts | Removed Emmet stylesheet select-item implementation |
| extensions/emmet/src/selectItemHTML.ts | Removed Emmet HTML select-item implementation |
| extensions/emmet/src/selectItem.ts | Removed Emmet select-item command wiring |
| extensions/emmet/src/removeTag.ts | Removed Emmet remove-tag command implementation |
| extensions/emmet/src/reflectCssValue.ts | Removed Emmet reflect CSS value command |
| extensions/emmet/src/parseDocument.ts | Removed Emmet parse cache + root node parsing |
| extensions/emmet/src/node/emmetNodeMain.ts | Removed Emmet node extension entrypoint |
| extensions/emmet/src/mergeLines.ts | Removed Emmet merge-lines command implementation |
| extensions/emmet/src/matchTag.ts | Removed Emmet match-tag command implementation |
| extensions/emmet/src/locateFile.ts | Removed Emmet helper for locating files |
| extensions/emmet/src/incrementDecrement.ts | Removed Emmet increment/decrement implementation |
| extensions/emmet/src/imageSizeHelper.ts | Removed Emmet image size helper |
| extensions/emmet/src/evaluateMathExpression.ts | Removed Emmet evaluate math expression command |
| extensions/emmet/src/emmetCommon.ts | Removed Emmet activation + command registrations |
| extensions/emmet/src/editPoint.ts | Removed Emmet edit-point navigation implementation |
| extensions/emmet/src/defaultCompletionProvider.ts | Removed Emmet completion provider implementation |
| extensions/emmet/src/bufferStream.ts | Removed Emmet document stream reader |
| extensions/emmet/src/browser/emmetBrowserMain.ts | Removed Emmet browser extension entrypoint |
| extensions/emmet/src/balance.ts | Removed Emmet balance in/out implementation |
| extensions/emmet/package.nls.json | Removed Emmet localization strings |
| extensions/emmet/extension.webpack.config.js | Removed Emmet node webpack build config |
| extensions/emmet/extension-browser.webpack.config.js | Removed Emmet browser webpack build config |
| extensions/emmet/cgmanifest.json | Removed Emmet CG manifest registration |
| extensions/emmet/README.md | Removed Emmet extension README |
| extensions/emmet/CONTRIBUTING.md | Removed Emmet contributing guide |
| extensions/emmet/.vscodeignore | Removed Emmet packaging ignore rules |
| extensions/emmet/.vscode/settings.json | Removed Emmet workspace settings |
| extensions/emmet/.vscode/launch.json | Removed Emmet debug launch configs |
| extensions/emmet/.npmrc | Removed Emmet npm config |
| extensions/docker/syntaxes/docker.tmLanguage.json | Removed Dockerfile grammar |
| extensions/docker/package.nls.json | Removed Docker language basics localization strings |
| extensions/docker/package.json | Removed Docker language basics extension manifest |
| extensions/docker/language-configuration.json | Removed Dockerfile language configuration |
| extensions/docker/cgmanifest.json | Removed Docker language basics CG manifest |
| extensions/docker/.vscodeignore | Removed Docker language basics packaging ignore rules |
| extensions/diff/syntaxes/diff.tmLanguage.json | Removed Diff grammar |
| extensions/diff/package.nls.json | Removed Diff language basics localization strings |
| extensions/diff/package.json | Removed Diff language basics extension manifest |
| extensions/diff/language-configuration.json | Removed Diff language configuration |
| extensions/diff/cgmanifest.json | Removed Diff language basics CG manifest |
| extensions/diff/.vscodeignore | Removed Diff language basics packaging ignore rules |
| extensions/debug-server-ready/tsconfig.json | Removed debug-server-ready TS build config |
| extensions/debug-server-ready/package.nls.json | Removed debug-server-ready localization strings |
| extensions/debug-server-ready/package.json | Removed debug-server-ready extension manifest |
| extensions/debug-server-ready/extension.webpack.config.js | Removed debug-server-ready webpack build config |
| extensions/debug-server-ready/.vscodeignore | Removed debug-server-ready packaging ignore rules |
| extensions/debug-server-ready/.vscode/launch.json | Removed debug-server-ready debug launch config |
| extensions/debug-server-ready/.npmrc | Removed debug-server-ready npm config |
| extensions/debug-auto-launch/tsconfig.json | Removed debug-auto-launch TS build config |
| extensions/debug-auto-launch/package.nls.json | Removed debug-auto-launch localization strings |
| extensions/debug-auto-launch/package.json | Removed debug-auto-launch extension manifest |
| extensions/debug-auto-launch/extension.webpack.config.js | Removed debug-auto-launch webpack build config |
| extensions/debug-auto-launch/.vscodeignore | Removed debug-auto-launch packaging ignore rules |
| extensions/debug-auto-launch/.vscode/launch.json | Removed debug-auto-launch debug launch config |
| extensions/debug-auto-launch/.npmrc | Removed debug-auto-launch npm config |
| extensions/dart/package.nls.json | Removed Dart language basics localization strings |
| extensions/dart/package.json | Removed Dart language basics extension manifest |
| extensions/dart/language-configuration.json | Removed Dart language configuration |
| extensions/dart/cgmanifest.json | Removed Dart language basics CG manifest |
| extensions/dart/.vscodeignore | Removed Dart language basics packaging ignore rules |
| extensions/css/package.nls.json | Removed CSS language basics localization strings |
| extensions/css/package.json | Removed CSS language basics extension manifest |
| extensions/css/language-configuration.json | Removed CSS language configuration |
| extensions/css/cgmanifest.json | Removed CSS language basics CG manifest |
| extensions/css/.vscodeignore | Removed CSS language basics packaging ignore rules |
| extensions/css/.vscode/launch.json | Removed CSS language basics debug launch config |
| extensions/css-language-features/test/mocha.opts | Removed CSS language features test mocha opts |
| extensions/css-language-features/server/tsconfig.json | Removed CSS language server TS build config |
| extensions/css-language-features/server/test/pathCompletionFixtures/src/test.js | Removed fixture header content |
| extensions/css-language-features/server/test/pathCompletionFixtures/src/feature.js | Removed fixture header content |
| extensions/css-language-features/server/test/pathCompletionFixtures/src/data/foo.asar | Removed fixture header content |
| extensions/css-language-features/server/test/pathCompletionFixtures/scss/main.scss | Removed fixture header content |
| extensions/css-language-features/server/test/pathCompletionFixtures/scss/_foo.scss | Removed fixture header content |
| extensions/css-language-features/server/test/pathCompletionFixtures/about/about.css | Removed fixture header content |
| extensions/css-language-features/server/test/pathCompletionFixtures/.foo.js | Removed fixture header content |
| extensions/css-language-features/server/test/linksTestFixtures/.gitignore | Removed links test fixture gitignore |
| extensions/css-language-features/server/test/index.js | Removed CSS language server test runner |
| extensions/css-language-features/server/src/utils/validation.ts | Removed diagnostics validation utilities |
| extensions/css-language-features/server/src/utils/strings.ts | Removed string helpers |
| extensions/css-language-features/server/src/utils/runner.ts | Removed async runner utilities |
| extensions/css-language-features/server/src/utils/documentContext.ts | Removed document context resolution |
| extensions/css-language-features/server/src/test/links.test.ts | Removed link provider unit tests |
| extensions/css-language-features/server/src/test/completion.test.ts | Removed completion unit tests |
| extensions/css-language-features/server/src/requests.ts | Removed FS request plumbing types |
| extensions/css-language-features/server/src/node/nodeFs.ts | Removed node FS request service |
| extensions/css-language-features/server/src/node/cssServerNodeMain.ts | Removed node server bootstrap |
| extensions/css-language-features/server/src/node/cssServerMain.ts | Removed node LSP server main |
| extensions/css-language-features/server/src/languageModelCache.ts | Removed language model cache |
| extensions/css-language-features/server/src/customData.ts | Removed custom data provider loader |
| extensions/css-language-features/server/src/browser/cssServerWorkerMain.ts | Removed browser worker bootstrap |
| extensions/css-language-features/server/src/browser/cssServerMain.ts | Removed browser LSP server main |
| extensions/css-language-features/server/package.json | Removed CSS language server package manifest |
| extensions/css-language-features/server/extension.webpack.config.js | Removed CSS server webpack config (node) |
| extensions/css-language-features/server/extension-browser.webpack.config.js | Removed CSS server webpack config (browser) |
| extensions/css-language-features/server/.vscode/tasks.json | Removed CSS server tasks config |
| extensions/css-language-features/server/.vscode/launch.json | Removed CSS server debug launch config |
| extensions/css-language-features/server/.npmrc | Removed CSS server npm config |
| extensions/css-language-features/schemas/package.schema.json | Removed schema for css.customData contributes |
| extensions/css-language-features/extension.webpack.config.js | Removed CSS client webpack config (node) |
| extensions/css-language-features/extension-browser.webpack.config.js | Removed CSS client webpack config (browser) |
| extensions/css-language-features/client/tsconfig.json | Removed CSS client TS build config |
| extensions/css-language-features/client/src/requests.ts | Removed client FS request serving |
| extensions/css-language-features/client/src/node/nodeFs.ts | Removed client node FS request service |
| extensions/css-language-features/client/src/node/cssClientMain.ts | Removed CSS client node entrypoint |
| extensions/css-language-features/client/src/dropOrPaste/uriList.ts | Removed drop/paste URI list handling |
| extensions/css-language-features/client/src/dropOrPaste/shared.ts | Removed drop/paste shared helpers |
| extensions/css-language-features/client/src/dropOrPaste/dropOrPasteResource.ts | Removed CSS drop/paste url() insertion provider |
| extensions/css-language-features/client/src/customData.ts | Removed custom data wiring on client |
| extensions/css-language-features/client/src/cssClient.ts | Removed language client setup |
| extensions/css-language-features/client/src/browser/cssClientMain.ts | Removed CSS client browser entrypoint |
| extensions/css-language-features/README.md | Removed CSS language features README |
| extensions/css-language-features/CONTRIBUTING.md | Removed CSS language features contributing guide |
| extensions/css-language-features/.vscodeignore | Removed CSS language features packaging ignore rules |
| extensions/css-language-features/.vscode/tasks.json | Removed CSS language features tasks config |
| extensions/css-language-features/.vscode/settings.json | Removed CSS language features workspace settings |
| extensions/css-language-features/.vscode/launch.json | Removed CSS language features debug launch config |
| extensions/css-language-features/.npmrc | Removed CSS language features npm config |
| extensions/csharp/snippets/csharp.code-snippets | Removed C# snippets |
| extensions/csharp/package.nls.json | Removed C# language basics localization strings |
| extensions/csharp/package.json | Removed C# language basics extension manifest |
| extensions/csharp/language-configuration.json | Removed C# language configuration |
| extensions/csharp/cgmanifest.json | Removed C# language basics CG manifest |
| extensions/csharp/.vscodeignore | Removed C# language basics packaging ignore rules |
| extensions/cpp/snippets/cpp.code-snippets | Removed C++ snippets |
| extensions/cpp/snippets/c.code-snippets | Removed C snippets |
| extensions/cpp/package.nls.json | Removed C/C++ language basics localization strings |
| extensions/cpp/package.json | Removed C/C++ language basics extension manifest |
| extensions/cpp/language-configuration.json | Removed C/C++ language configuration |
| extensions/cpp/cgmanifest.json | Removed C/C++ language basics CG manifest |
| extensions/cpp/build/update-grammars.js | Removed C/C++ grammar update utility |
| extensions/cpp/.vscodeignore | Removed C/C++ packaging ignore rules |
| extensions/configuration-editing/tsconfig.json | Removed configuration-editing TS build config |
| extensions/configuration-editing/src/test/index.ts | Removed configuration-editing integration test runner |
| extensions/configuration-editing/src/node/net.ts | Removed proxy agent helper |
| extensions/configuration-editing/src/importExportProfiles.ts | Removed profile import/export gist handler |
| extensions/configuration-editing/src/extensionsProposals.ts | Removed extension recommendation proposals |
| extensions/configuration-editing/src/browser/net.ts | Removed browser net shim |
| extensions/configuration-editing/schemas/devContainer.vscode.schema.json | Removed devcontainer VS Code schema |
| extensions/configuration-editing/schemas/devContainer.codespaces.schema.json | Removed devcontainer codespaces schema |
| extensions/configuration-editing/schemas/attachContainer.schema.json | Removed attach container schema |
| extensions/configuration-editing/package.nls.json | Removed configuration-editing localization strings |
| extensions/configuration-editing/package.json | Removed configuration-editing extension manifest |
| extensions/configuration-editing/extension.webpack.config.js | Removed configuration-editing webpack config (node) |
| extensions/configuration-editing/extension-browser.webpack.config.js | Removed configuration-editing webpack config (browser) |
| extensions/configuration-editing/.vscodeignore | Removed configuration-editing packaging ignore rules |
| extensions/configuration-editing/.npmrc | Removed configuration-editing npm config |
| extensions/coffeescript/snippets/coffeescript.code-snippets | Removed CoffeeScript snippets |
| extensions/coffeescript/package.nls.json | Removed CoffeeScript language basics localization strings |
| extensions/coffeescript/package.json | Removed CoffeeScript language basics extension manifest |
| extensions/coffeescript/language-configuration.json | Removed CoffeeScript language configuration |
| extensions/coffeescript/cgmanifest.json | Removed CoffeeScript language basics CG manifest |
| extensions/coffeescript/.vscodeignore | Removed CoffeeScript packaging ignore rules |
| extensions/clojure/package.nls.json | Removed Clojure language basics localization strings |
| extensions/clojure/package.json | Removed Clojure language basics extension manifest |
| extensions/clojure/language-configuration.json | Removed Clojure language configuration |
| extensions/clojure/cgmanifest.json | Removed Clojure language basics CG manifest |
| extensions/clojure/.vscodeignore | Removed Clojure packaging ignore rules |
| extensions/bat/snippets/batchfile.code-snippets | Removed Windows batch snippets |
| extensions/bat/package.nls.json | Removed bat language basics localization strings |
| extensions/bat/package.json | Removed bat language basics extension manifest |
| extensions/bat/language-configuration.json | Removed bat language configuration |
| extensions/bat/cgmanifest.json | Removed bat language basics CG manifest |
| extensions/bat/.vscodeignore | Removed bat packaging ignore rules |
| extensions/cgmanifest.json | Removed extensions-level CG manifest |
| extensions/.npmrc | Removed extensions-level npm config |
| .npmrc | Added a node-gyp compilation flag setting |
| .devcontainer/devcontainer.json | Updated devcontainer remote user and features |
| .devcontainer/devcontainer-lock.json | Updated devcontainer feature lockfile to match feature changes |
Files not reviewed (6)
- extensions/configuration-editing/package-lock.json: Language not supported
- extensions/css-language-features/package-lock.json: Language not supported
- extensions/css-language-features/server/package-lock.json: Language not supported
- extensions/debug-auto-launch/package-lock.json: Language not supported
- extensions/debug-server-ready/package-lock.json: Language not supported
- extensions/emmet/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| build_from_source="true" | ||
| legacy-peer-deps="true" | ||
| timeout=180000 | ||
| node_gyp_cflags=-std=c++20 |
There was a problem hiding this comment.
node_gyp_cflags is not a standard npm/node-gyp config key, so this is unlikely to have any effect on native module builds. Consider using standard knobs such as cflags/cxxflags in .npmrc (which npm passes through as npm_config_cflags/npm_config_cxxflags) or setting CXXFLAGS in the relevant build environment instead, ideally scoped to only the dependency(ies) that require C++20.
| node_gyp_cflags=-std=c++20 | |
| cxxflags=-std=c++20 |
| { | ||
| "name": "Code - OSS", | ||
| "remoteUser": "node", | ||
| "updateRemoteUserUID": true, | ||
| "build": { | ||
| "dockerfile": "Dockerfile" | ||
| }, | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/desktop-lite:1": {}, | ||
| "ghcr.io/devcontainers/features/rust:1": {} | ||
| "ghcr.io/devcontainers/features/desktop-lite:1": {} | ||
| }, |
There was a problem hiding this comment.
Line 4 uses spaces while the surrounding file uses tabs, which can cause noisy diffs and fail formatting/lint checks in repos that enforce consistent indentation. Reformat the new property to match the file’s existing indentation style.
…mic positioning, navigation, and element inspection.
… browser, while ensuring proper navigation event handling.
No description provided.