Open
Conversation
codingjoe
reviewed
Aug 11, 2025
Member
codingjoe
left a comment
There was a problem hiding this comment.
Hi there 👋,
Thanks for reaching out and your submission. The implementation looks pretty clean, but please still consider starting a discussion or issue next before a PR to smoothen the process.
Generally, this feature looks very Slack-specific. I feel like the user management should be happening inside Slack, not here. There might already be a way to do this. Have you looked into this and maybe mind sharing your findings?
Other than that, this should be SLACK_ALLOWED_USERS with a prefix, and we try to avoid black-and-white terms largely.
Best
Joe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful if you don't want everyone to be able to interact with the bot.