Skip to content

test: Enhance tests for RLE and PCO casting: add assertions for dtype…#6726

Open
SYaoJun wants to merge 3 commits intovortex-data:developfrom
SYaoJun:0301_test
Open

test: Enhance tests for RLE and PCO casting: add assertions for dtype…#6726
SYaoJun wants to merge 3 commits intovortex-data:developfrom
SYaoJun:0301_test

Conversation

@SYaoJun
Copy link
Contributor

@SYaoJun SYaoJun commented Mar 1, 2026

… preservation and validity after nullability changes

Summary

Two tests were only asserting on the output dtype after a cast operation,
without verifying that the actual values were correctly preserved. This
means the tests would pass even if the cast silently corrupted data.

Closes: #000

Testing

tests passed

… preservation and validity after nullability changes

Signed-off-by: syaojun <libevent@yeah.net>
@connortsui20 connortsui20 enabled auto-merge (squash) March 1, 2026 13:22
@connortsui20
Copy link
Contributor

Thanks for the PR!

@connortsui20 connortsui20 added the changelog/chore A trivial change label Mar 1, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 1, 2026

Merging this PR will improve performance by 12.36%

⚡ 2 improved benchmarks
✅ 952 untouched benchmarks
⏩ 1466 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation map_each[BufferMut<i32>, 128] 858.1 ns 770.6 ns +11.36%
Simulation bitwise_not_vortex_buffer_mut[128] 530.3 ns 471.9 ns +12.36%

Comparing SYaoJun:0301_test (e31b284) with develop (fb71117)

Open in CodSpeed

Footnotes

  1. 1466 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gatesn gatesn disabled auto-merge March 1, 2026 13:34
@connortsui20
Copy link
Contributor

@SYaoJun Could you fix the lint? Then we should be good to go. Don't worry about the perf regression, it's just wrong :/

Signed-off-by: syaojun <libevent@yeah.net>
@SYaoJun
Copy link
Contributor Author

SYaoJun commented Mar 2, 2026

@SYaoJun Could you fix the lint? Then we should be good to go. Don't worry about the perf regression, it's just wrong :/

I have fixed the lint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants