test: Enhance tests for RLE and PCO casting: add assertions for dtype…#6726
Open
SYaoJun wants to merge 3 commits intovortex-data:developfrom
Open
test: Enhance tests for RLE and PCO casting: add assertions for dtype…#6726SYaoJun wants to merge 3 commits intovortex-data:developfrom
SYaoJun wants to merge 3 commits intovortex-data:developfrom
Conversation
… preservation and validity after nullability changes Signed-off-by: syaojun <libevent@yeah.net>
connortsui20
approved these changes
Mar 1, 2026
Contributor
|
Thanks for the PR! |
Merging this PR will improve performance by 12.36%
Performance Changes
Comparing Footnotes
|
Contributor
|
@SYaoJun Could you fix the lint? Then we should be good to go. Don't worry about the perf regression, it's just wrong :/ |
Signed-off-by: syaojun <libevent@yeah.net>
Contributor
Author
I have fixed the lint. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… preservation and validity after nullability changes
Summary
Two tests were only asserting on the output dtype after a cast operation,
without verifying that the actual values were correctly preserved. This
means the tests would pass even if the cast silently corrupted data.
Closes: #000
Testing
tests passed