Skip to content

lws/mbedtls-wrapper: Align SSL_CTX_new function declaration with OpenSSL#3477

Open
ThePassionate wants to merge 1 commit intowarmcat:mainfrom
ThePassionate:ssl-openssl
Open

lws/mbedtls-wrapper: Align SSL_CTX_new function declaration with OpenSSL#3477
ThePassionate wants to merge 1 commit intowarmcat:mainfrom
ThePassionate:ssl-openssl

Conversation

@ThePassionate
Copy link
Contributor

SSL_CTX *SSL_CTX_new(const SSL_METHOD *meth) is the declaration of openssl.
We hope that the OpenSSL interface in mbedtls-wrapper can also align with the OpenSSL real declaration.

@lws-team
Copy link
Member

/home/sai/jobs/85984169/src/ebuild/esp-heltec-wb32/libwebsockets/lib/tls/mbedtls/wrapper/library/ssl_lib.c: In function 'SSL_CTX_new':
/home/sai/jobs/85984169/src/ebuild/esp-heltec-wb32/libwebsockets/lib/tls/mbedtls/wrapper/library/ssl_lib.c:208:25: error: 'rngctx' undeclared (first use in this function)
  208 |     cert = ssl_cert_new(rngctx);

... did you build-test it?

SSL_CTX *SSL_CTX_new(const SSL_METHOD *meth) is the declaration of openssl

Signed-off-by: makejian <makejian@xiaomi.com>
@ThePassionate
Copy link
Contributor Author

/home/sai/jobs/85984169/src/ebuild/esp-heltec-wb32/libwebsockets/lib/tls/mbedtls/wrapper/library/ssl_lib.c: In function 'SSL_CTX_new':
/home/sai/jobs/85984169/src/ebuild/esp-heltec-wb32/libwebsockets/lib/tls/mbedtls/wrapper/library/ssl_lib.c:208:25: error: 'rngctx' undeclared (first use in this function)
  208 |     cert = ssl_cert_new(rngctx);

... did you build-test it?

Sorry, I had the mbedtls backend misconfigured in my compilation tests. The latest patch is now updated - could you please review and test it again? Thanks a lot!

@lws-team lws-team force-pushed the main branch 5 times, most recently from a677221 to 0c67054 Compare October 24, 2025 16:36
@lws-team lws-team force-pushed the main branch 2 times, most recently from f5fa440 to 278c671 Compare November 6, 2025 08:28
@lws-team lws-team force-pushed the main branch 2 times, most recently from 580b993 to c837e3f Compare December 29, 2025 15:24
@lws-team lws-team force-pushed the main branch 9 times, most recently from 260929d to f06bf53 Compare January 25, 2026 20:25
@lws-team lws-team force-pushed the main branch 4 times, most recently from fb3f410 to d8c745e Compare February 4, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants