lws/mbedtls-wrapper: Align SSL_CTX_new function declaration with OpenSSL#3477
Open
ThePassionate wants to merge 1 commit intowarmcat:mainfrom
Open
lws/mbedtls-wrapper: Align SSL_CTX_new function declaration with OpenSSL#3477ThePassionate wants to merge 1 commit intowarmcat:mainfrom
ThePassionate wants to merge 1 commit intowarmcat:mainfrom
Conversation
Member
... did you build-test it? |
7334f9a to
b3d5dab
Compare
SSL_CTX *SSL_CTX_new(const SSL_METHOD *meth) is the declaration of openssl Signed-off-by: makejian <makejian@xiaomi.com>
b3d5dab to
4076612
Compare
Contributor
Author
Sorry, I had the mbedtls backend misconfigured in my compilation tests. The latest patch is now updated - could you please review and test it again? Thanks a lot! |
a677221 to
0c67054
Compare
f5fa440 to
278c671
Compare
580b993 to
c837e3f
Compare
260929d to
f06bf53
Compare
fb3f410 to
d8c745e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSL_CTX *SSL_CTX_new(const SSL_METHOD *meth) is the declaration of openssl.
We hope that the OpenSSL interface in mbedtls-wrapper can also align with the OpenSSL real declaration.