refactor: move exports info initialize to finish modules#13139
Draft
refactor: move exports info initialize to finish modules#13139
Conversation
github-actions
bot
added
release: refactor
team
Contributor
📦 Binary Size-limit
🎉 Size decreased by 6.88KB from 48.83MB to 48.83MB (⬇️0.01%) |
Contributor
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is just for preserve the changes, for now I will move on and work on something else, may back to work on this again in future
Current status:
pnpm test:base -t "compilation/rebuild-module"is the blocker, need a new way to record correctly what module is added, andnew_exports_info()for new added modules (affected_modules.added()is not work forrebuildModule)Related links
Checklist