Conversation
anhu
left a comment
anhu
left a comment
There was a problem hiding this comment.
In each \brief section it says "This macro...."
While its true they are macros, I think it should say "This function..." or method or something else.
On the same token, do you think it would be good to eliminate the wc_Dilithium_xxx lines?
|
|
Yes. Eventually, that mapping will go away. Its an implementation detail, not an interface detail. |
# Conflicts: # doc/dox_comments/header_files/doxygen_pages.h
anhu
left a comment
anhu
left a comment
There was a problem hiding this comment.
There are many odd and troubling mistakes in here. Perhaps get another AI to review this PR as well.
|
|
||
| \sa wc_MlDsaKey_SetParams | ||
| */ | ||
| int wc_MlDsaKey_GetParams(MlDsaKey *key, byte id); |
| \sa wc_MlDsaKey_Sign | ||
| \sa wc_MlDsaKey_Verify | ||
| */ | ||
| int wc_MlDsaKey_MakeKey(MlDsaKey *key, WC_RNG *rrng); |
|
|
||
| \param key pointer to the MlDsaKey structure containing a private key | ||
| \param out output buffer for raw private key | ||
| \param outLen in/out: on input, size of out; on output, bytes written (implementation dependent) |
There was a problem hiding this comment.
why does it say "(implementation dependent)" ? Seems odd. Actually there are many instances of this and they all seem odd.
| \sa wc_MlDsaKey_Verify | ||
| \sa wc_MlDsaKey_GetSigLen | ||
| */ | ||
| int wc_MlDsaKey_Sign(MlDsaKey *key, byte *sig, word32 sigSz, const byte *msg, word32 sgSz, WC_RNG *rng); |
|
|
||
| _Example_ | ||
| \code | ||
| word32 ctSz, ssSz; |
There was a problem hiding this comment.
would be nice if this showed RNG initialization as well.
| byte* ct = XMALLOC(ctSz, NULL, DYNAMIC_TYPE_TMP_BUFFER); | ||
| byte* ss = XMALLOC(ssSz, NULL, DYNAMIC_TYPE_TMP_BUFFER); | ||
|
|
| wc_MlKemKey_SharedSecretSize(&myPriv, &ssSz); | ||
|
|
||
| byte ss2[WC_ML_KEM_SS_SZ]; // if using fixed 32-byte SS | ||
| wc_MlKemKey_Decapsulate(&myPriv, ss2, ct, ctSz); |
3 participants
Description
Please describe the scope of the fix or feature addition.
Fixes zd#
Testing
How did you test?
Checklist